Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When "remove_slience" is set to "true" sometime STT fails with short words #110

Closed
goldyfruit opened this issue Apr 15, 2024 · 2 comments · Fixed by #114
Closed

When "remove_slience" is set to "true" sometime STT fails with short words #110

goldyfruit opened this issue Apr 15, 2024 · 2 comments · Fixed by #114
Assignees
@JarbasAl
Labels
bug Something isn't working

Comments

@goldyfruit
Copy link
Member

If remove_slience: true is set in mycroft.conf, STT can't (Chromium), can't understand the transcription and returns an error in the logs.

The word was stop.

Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]: 2024-04-15 14:52:10.925 - voice - ovos_dinkum_listener.plugins:finalize:35 - ERROR - Error in STT plugin: ChromiumSTT
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]: Traceback (most recent call last):
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_dinkum_listener/plugins.py", line 30, in finalize
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:     transcript = self.engine.execute(audio, self.language)
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_stt_plugin_chromium/__init__.py", line 248, in execute
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:     data = json.loads(result)["result"]
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:            ^^^^^^^^^^^^^^^^^^
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:   File "/usr/lib/python3.11/json/__init__.py", line 346, in loads
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:     return _default_decoder.decode(s)
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:   File "/usr/lib/python3.11/json/decoder.py", line 337, in decode
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:     obj, end = self.raw_decode(s, idx=_w(s, 0).end())
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:   File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]:     raise JSONDecodeError("Expecting value", s, err.value) from None
Apr 15 14:52:10 mark2 ovos-dinkum-listener[3700]: json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
@JarbasAl
Copy link
Member

will probably happen with most single word commands, a check should be added in remove_silence to ensure min_audio

above seems like a empty audio was sent

@goldyfruit
Copy link
Member Author

goldyfruit commented Apr 15, 2024 •
edited
Loading

When remove_slience is set to false, "stop" word gets detected by STT.

NeonDaniel added a commit that referenced this issue Apr 25, 2024
@NeonDaniel
Move timer reset to ensure minimum recording length is measured from …
ba73782 
…the moment input is accepted

Related to #107
Related to #110
This was referenced Apr 25, 2024
Closed
Merged
NeonDaniel added a commit to NeonGeckoCom/neon_speech that referenced this issue Apr 25, 2024
@NeonDaniel
Revert ovos-dinkum-listener dependency to previous validated version (#…
7753088 
…197)

# Description
Rolls back update to ovos-dinkum-listener dependency included in release
4.4.0

# Issues
OpenVoiceOS/ovos-dinkum-listener#98
OpenVoiceOS/ovos-dinkum-listener#107
OpenVoiceOS/ovos-dinkum-listener#110

# Other Notes
<!-- Note any breaking changes, WIP changes, requests for input, etc.
here -->

Co-authored-by: Daniel McKnight <[email protected]>
@JarbasAl JarbasAl mentioned this issue May 11, 2024
Closed
JarbasAl added a commit that referenced this issue Jun 2, 2024
@JarbasAl
fix/ensure_min_audio_len
db2be26 
fixes #110
@JarbasAl JarbasAl mentioned this issue Jun 2, 2024
Merged
@JarbasAl JarbasAl added the bug Something isn't working label Jun 2, 2024
@JarbasAl JarbasAl mentioned this issue Jun 3, 2024
Closed
4 tasks
@JarbasAl JarbasAl self-assigned this Jun 3, 2024
JarbasAl added a commit that referenced this issue Jun 6, 2024
@JarbasAl
fix/ensure_min_audio_len (#114)
1b14726 
* fix/ensure_min_audio_len

fixes #110

* debug logs

* include all timing info in debug logs

* simplify logs further

* move into helper method for readibility
@github-actions github-actions bot mentioned this issue Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JarbasAl JarbasAl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/ensure_min_audio_len OpenVoiceOS/ovos-dinkum-listener
2 participants
@goldyfruit @JarbasAl