Add pull secret option to operator also #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlbiam I consider this pretty simple extension. Would you be so kind to review pls? We want to upstream fixes we made recently so we can switch back to upstream. Happy to rename vars as you see fit. I used same as in other charts right now. |
|
we have this fixed in the latest beta. let me do a compare on that |
|
Thank you for the info @mlbiam, waiting for 1.0.24 |
|
Pls also note #21 from my colleague which would be a very nice to have also when using custom certs config via cert-manager automation like letsencrypt. Thank you |
|
The latest version of the operator has this feature built in ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to use private docker repository mirror here also