Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for harcoding as while using lets-encrypt option of having cont… #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

librannk
Copy link

@librannk librannk commented Jun 1, 2021

…rol over the name of certificates helps

@mlbiam
Copy link
Contributor

mlbiam commented Nov 18, 2021

I was about to merge this into the new helm charts, but the more i think about it why is this needed? If you're using Let's Encrypt via either an annotation on the Ingress or by manually creating a Certificate object you can have the resulting secret named unison-tls. What benefit is there of adding a new configuration option? Can you explain your usecase?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants