Optimize performance when Git is used as storage repository #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calling `git log` with a wildcard `*` pattern
MattiSG
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Thank you for the benchmarks, this looks amazing!
Thanks a lot @michielbdejong for the experiments and suggestions, I'm thrilled to see this land and am looking forward to the impact this will have on tracking performance across collections!
| return this.recordVersion(terms, extractOnly); | ||
| await this.recordVersion(terms, extractOnly); | ||
|
|
||
| terms.sourceDocuments.forEach(sourceDocument => { |
There was a problem hiding this comment.
Why can't we just do
terms.sourceDocuments = []orterms.sourceDocuments = null?
There was a problem hiding this comment.
Because doing so would result in losing information needed for the next run, such as location, contentSelectors, …
Co-authored-by: Matti Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several optimizations to improve performance and memory usage:
Technical improvements:
git logcommands with specific pathscommit-graphfor faster commit history traversal (fixes Consider taking advantage of git commit-graph #1101)Performance benchmarks:
Testing was performed on two distinct datasets:
ToS;DR Collection
P2B Compliance Collection
The optimizations show greater impact on collections with larger numbers of declared services and terms.
Fixes #1101. Special thanks to @michielbdejong for reporting the issue, investigating, and providing valuable suggestions 🙏