-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft for discussion: Feature/add elements to measurement state #660
base: master
Are you sure you want to change the base?
Draft for discussion: Feature/add elements to measurement state #660
Conversation
elements: NEW, PARTIALLY_MEASURED, PREDICED_OCCLUDED Issue: OpenSimulationInterface#646 Signed-off-by: FlorianMueller87 <[email protected]>
Issue: OpenSimulationInterface#648 Signed-off-by: FlorianMueller87 <[email protected]>
258a871
to
7293b45
Compare
osi_detectedobject.proto
Outdated
|
||
// Tracked object is temporarily occluded by another entity. | ||
// | ||
MEASUREMENT_STATE_PREDICED_OCCLUDED = 6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prediced or PREDICTED? Where is the differnece to state predicted above?
osi_detectedobject.proto
Outdated
// object. The remaining signals of this object are unchanged | ||
// or predicted for this measurement cycle. | ||
// | ||
MEASUREMENT_STATE_PARTIALLY_MEASURED = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PARTLY_MEASURED in ISO23150?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PARTLY_MEASURED is correct. This is a mistake on ADI side.
Comment:
|
|
I personally think that PARTIALLY_MEASURED is in terms of the English language correct. If that is a non-binding example from the annex again you are also not "wrong" in ADI as it is just an example :)) |
Comment from WG Harmonization: |
Reference to a related issue in the repository
#648
Add a description
ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.
ASAM OSI need the entries for osi_detectedobject – DetectedItemHeader – MeasurementState to be compatible with AUTOSAR ADI MeasurementStatus.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
Additional context
ISO23150:2021 A.2.9 Measurement status – object level
@ThomasNaderBMW @jdsika @schmidtlorenz