Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for discussion: Feature/add elements to measurement state #660

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

FlorianMueller87
Copy link
Contributor

@FlorianMueller87 FlorianMueller87 commented Aug 9, 2022

Reference to a related issue in the repository

#648

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_detectedobject – DetectedItemHeader – MeasurementState to be compatible with AUTOSAR ADI MeasurementStatus.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

Additional context

ISO23150:2021 A.2.9 Measurement status – object level
@ThomasNaderBMW @jdsika @schmidtlorenz

elements: NEW, PARTIALLY_MEASURED, PREDICED_OCCLUDED

Issue: OpenSimulationInterface#646
Signed-off-by: FlorianMueller87 <[email protected]>
@FlorianMueller87 FlorianMueller87 force-pushed the feature/add_elements_to_MeasurementState branch from 258a871 to 7293b45 Compare August 12, 2022 07:07
@jdsika jdsika added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Oct 17, 2022

// Tracked object is temporarily occluded by another entity.
//
MEASUREMENT_STATE_PREDICED_OCCLUDED = 6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prediced or PREDICTED? Where is the differnece to state predicted above?

// object. The remaining signals of this object are unchanged
// or predicted for this measurement cycle.
//
MEASUREMENT_STATE_PARTIALLY_MEASURED = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PARTLY_MEASURED in ISO23150?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PARTLY_MEASURED is correct. This is a mistake on ADI side.

@jdsika
Copy link
Contributor

jdsika commented Oct 17, 2022

Comment:

  • @carsten-kuebler we need some better explanations in the ISO what is the reason and difference for PREDICTED_OCCLUDED and PREDICTED?
  • HOW is something INVALID?

@jdsika jdsika added this to the V3.6.0 milestone Oct 17, 2022
@FlorianMueller87
Copy link
Contributor Author

@jdsika

  • PREDICTED: sorry typo, thanks.
  • ISO definition: PREDICTED: The object was predicted without any new information with respect to the previous update cycle.
  • ISO definition: PREDICTED_OCCLUDED: Tracked object is temporarily occluded by another entity.
  • PARTLY_MEASURED in ISO23150: It is wrong in ADI. We will chang this in ADI and I will correct this here.
  • INVALID: The measurement result is invalid. : My thought on this is e.g. two sensors getting different results. I will discuss this on ADI board.

@jdsika
Copy link
Contributor

jdsika commented Nov 2, 2022

I personally think that PARTIALLY_MEASURED is in terms of the English language correct. If that is a non-binding example from the annex again you are also not "wrong" in ADI as it is just an example :))
But the explanation/definition of the word is actually the important thing and if a Tier1 needs/uses a signal with that definition.

@thempen
Copy link
Contributor

thempen commented Dec 7, 2022

Comment from WG Harmonization:
Please provide further information on when to use the suggested measurement states and what additional information can be gathered in addition to the existing description.
It is unclear how to use it together with the existence_probability and age fields.

@ClemensLinnhoff ClemensLinnhoff added the AUTOSAR ADI Topics connected to AUTOSAR ADI definition. label Mar 3, 2023
@jdsika jdsika modified the milestones: V3.6.0, V4.0.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AUTOSAR ADI Topics connected to AUTOSAR ADI definition. Harmonisation The Group in the ASAM development project working on harmonisation with other standards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISO23150 compliance: Adding new states to [DetectedItemHeader – MeasurementState]
4 participants