Update engine to playtest 20201213 #764

kienanstewart · 2021-01-26T22:44:01Z

Hi,

there are few issues (eg. #709 and #702) that require engine updates to work properly. Given that there was a new playtest engine cut recently I figured I would try to see if I could do some of the work required.

It's not done yet - I have the code compiling, but not the game starting with content yet.

If y'all prefer not having WIP PR's, we can close this until I have something more tangible.

thanks,

TODO:

The colour of pips are wrong, and the default size is too small
[N/A] Turret bases appear over the tops (most easily visible with the Grand Cannon)
- Engine issue: Voxel Models appear to be cropped in certain circumstances. OpenRA#18930

Fixes running the game when the dylib's aren't found in the system path

kienanstewart · 2021-01-27T05:08:59Z

A few things that I've yet to fix:

Vehicle turn (and turret turn) speeds are very slow. Probably related to switching to WAngle
Transports don't show capacity pips
Minimap rendering wrong
Vehicle placement when deploying from war factory and refinery seems off
Harvesters dock backwards to the refineries

Crash when Blackhawk attacks:

Exception of type System.InvalidOperationException: Unit shad does not have a sequence named muzzle

Wrench icon when repairing buildings is offset and doesn't appear above the building itself
Crash when destroyed attack submarine with osprey

abcdefg30 · 2021-01-27T19:29:15Z

We'll also need to add the upstream ModSDK changes once they are merged.

kienanstewart · 2021-01-28T23:10:03Z

@abcdefg30 could you elaborate a bit on the modsdk changes that are expected? thanks for bringing up that there is something to look out for

Fixes minimaps

Fixes crashes when loading infantry with CustomPipType set into transports

Fixes a number of decoration display issues

pgwipeout · 2021-01-30T19:26:04Z

Either I'm doing something wrong, or something is squirrely here.
I can't get this to run as is.

launch-game.cmd
Required engine files not found.
Run `make all` in the mod directory to fetch and build the required files, then try again.
Press any key to continue . . .

It seems OpenRA.Game.exe is not built by the engine anymore.
Running the base game from the engine folder works fine.

EDIT:
I see, you are running only on Linux.

pgwipeout

This allows the game to start on Windows, but crashes due to the missing glyphs.png required for fractional scaling.

Exception of type `System.IO.FileNotFoundException\`: File not found: glyphs.png
  at OpenRA.FileSystem.FileSystem.Open(String filename) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\FileSystem\FileSystem.cs:line 206
   at OpenRA.Graphics.ChromeProvider.SheetForCollection(Collection c) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Graphics\ChromeProvider.cs:line 133
   at OpenRA.Graphics.ChromeProvider.GetImage(String collectionName, String imageName) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Graphics\ChromeProvider.cs:line 168
   at OpenRA.Mods.Common.Widgets.DropDownButtonWidget.Draw() in C:\Users\pgwip\openra\ra2\engine\OpenRA.Mods.Common\Widgets\DropDownButtonWidget.cs:line 56
   at OpenRA.Widgets.Widget.DrawOuter() in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Widgets\Widget.cs:line 453
   at OpenRA.Widgets.Widget.DrawOuter() in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Widgets\Widget.cs:line 453
   at OpenRA.Widgets.Widget.DrawOuter() in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Widgets\Widget.cs:line 453
   at OpenRA.Widgets.Widget.DrawOuter() in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Widgets\Widget.cs:line 453
   at OpenRA.Game.RenderTick() in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Game.cs:line 703
   at OpenRA.Game.Loop() in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Game.cs:line 834
   at OpenRA.Game.Run() in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Game.cs:line 852
   at OpenRA.Game.InitializeAndRun(String[] args) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\Game.cs:line 270
   at OpenRA.Launcher.Program.Main(String[] args) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Launcher\Program.cs:line 26

I copied chrome.png to glyphs.png and it fixed this issue, but you'll need the original designer to export the 2x and 3x files.
make test also crashes instantly with the following error:

Unhandled Exception: System.IO.FileNotFoundException: File not found: ^EngineDir|./mods/common
   at OpenRA.FileSystem.FileSystem.Open(String filename) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\FileSystem\FileSystem.cs:line 206
   at OpenRA.FileSystem.FileSystem.OpenPackage(String filename) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\FileSystem\FileSystem.cs:line 81
   at OpenRA.FileSystem.FileSystem.Mount(String name, String explicitName) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\FileSystem\FileSystem.cs:line 115
   at OpenRA.FileSystem.FileSystem.LoadFromManifest(Manifest manifest) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\FileSystem\FileSystem.cs:line 191
   at OpenRA.ModData..ctor(Manifest mod, InstalledMods mods, Boolean useLoadScreen) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Game\ModData.cs:line 60
   at OpenRA.Program.Main(String[] args) in C:\Users\pgwip\openra\ra2\engine\OpenRA.Utility\Program.cs:line 79

pgwipeout · 2021-02-02T12:52:30Z

launch-game.cmd

@@ -5,18 +5,18 @@ title OpenRA
 FOR /F "tokens=1,2 delims==" %%A IN (mod.config) DO (set %%A=%%B)
 if exist user.config (FOR /F "tokens=1,2 delims==" %%A IN (user.config) DO (set %%A=%%B))
 set TEMPLATE_LAUNCHER=%0
-set MOD_SEARCH_PATHS=%~dp0mods,./mods
+set MOD_SEARCH_PATHS=%~dp0mods,../mods


Per the OpenRA SDK this should stay as it was.

I copied glyphs.png from RA and it seems to work "ok" in that I see the flags and such that I expect. Copying chrome.png I saw pieces of the ui bars instead of flags.

Do you know where glyphs.png should come from normally?

OpenRA/OpenRA@1282650
This is the commit that introduced them in the engine.
I believe they are modified and split up versions of the original.

Interesting though, I don't see any artifacts using them on Windows.
Might be also why it didn't cause issues on linux.

pgwipeout · 2021-02-02T12:53:23Z

launch-game.cmd


 if "!MOD_ID!" == "" goto badconfig
 if "!ENGINE_VERSION!" == "" goto badconfig
 if "!ENGINE_DIRECTORY!" == "" goto badconfig

 set TEMPLATE_DIR=%CD%
-if not exist %ENGINE_DIRECTORY%\OpenRA.Game.exe goto noengine
+if not exist %ENGINE_DIRECTORY%\bin\OpenRA.Game.exe goto noengine


This should be: if not exist %ENGINE_DIRECTORY%\bin\OpenRA.exe goto noengine

pgwipeout · 2021-02-02T12:53:54Z

launch-game.cmd

 >nul find %ENGINE_VERSION% %ENGINE_DIRECTORY%\VERSION || goto noengine
 cd %ENGINE_DIRECTORY%

-OpenRA.Game.exe Game.Mod=%MOD_ID% Engine.LaunchPath="%TEMPLATE_LAUNCHER%" "Engine.ModSearchPaths=%MOD_SEARCH_PATHS%"  "%*"
+bin\OpenRA.Game.exe Game.Mod=%MOD_ID% Engine.LaunchPath="%TEMPLATE_LAUNCHER%" "Engine.ModSearchPaths=%MOD_SEARCH_PATHS%"  "%*"


This should be: bin\OpenRA.exe Game.Mod=%MOD_ID% Engine.EngineDir=".." Engine.LaunchPath="%TEMPLATE_LAUNCHER%" "Engine.ModSearchPaths=%MOD_SEARCH_PATHS%" "%*"

Thanks for all the feedback on the launcher. I wasn't aware of the https://github.com/OpenRA/OpenRAModSDK project. I will merge the changes there since the tag 20200503 (with the exception of the last commit for the playtest that came out the other day). That should hopefully solve all of these more systematically than what I was doing.

Not a problem, I'll continue to track this and test on Windows.
I've been looking to get into helping with this project, and your work has been the kick in the pants I needed.

pgwipeout · 2021-02-02T13:30:25Z

A few notes in my first run of the game.
Doggos are glitchy in attacks.
Missiles still fly way too slow.
Mirage Tanks are trees, but not stealthed.
I crashed the game when I tried to make a spy take the form of a rocketeer, because they can't fly.

kienanstewart · 2021-02-02T16:20:26Z

A few notes in my first run of the game.
Doggos are glitchy in attacks.
Missiles still fly way too slow.
Mirage Tanks are trees, but not stealthed.
I crashed the game when I tried to make a spy take the form of a rocketeer, because they can't fly.

These seem to also be issues pre-engine upgrade, so changing the engine shouldn't address them? I don't see relevant open issues for any of them though.

pgwipeout · 2021-02-02T17:19:00Z

A few notes in my first run of the game.
Doggos are glitchy in attacks.
Missiles still fly way too slow.
Mirage Tanks are trees, but not stealthed.
I crashed the game when I tried to make a spy take the form of a rocketeer, because they can't fly.

These seem to also be issues pre-engine upgrade, so changing the engine shouldn't address them? I don't see relevant open issues for any of them though.

I've doubled missile default flight speed and it helps. Gotta check against vanilla and tune from here.
I thought they had fixed the dog attack, I'll have to go back and check.
I'm looking for a fix for the Spy issue, then I'll look into the mirage tanks.
I also noticed the Naval Yard (at least on Alliance side) is missing all of the shadow in the construction area.

Updated chrome.yaml to use them for some decorations that weren't working properly.

kienanstewart · 2021-02-02T21:15:45Z

I also noticed the Naval Yard (at least on Alliance side) is missing all of the shadow in the construction area.

The shadows look the same to me between pre-engine upgrade and post-engine upgrade. I think this might be a separate issue.

I've cleared out everything I noticed from the engine upgrade so I'll remove the 'WIP' tag so folks can look at it more. Note: during the ModSDK changes I removed the travis CI, I think the project needs to be reconfigured with the github actions instead. However, if desired I'll add back travis.yaml

Mailaender · 2021-04-03T10:34:32Z

Putting configuration files in the .github folder is enough. Sadly we can't test it until this pull request is merged.

LinuxDonald · 2021-04-03T21:25:57Z

@MustaphaTR could you maybe merge it?

abcdefg30 · 2021-04-03T21:36:34Z

OpenRA.Mods.RA2/Traits/PeriodicExplosion.cs

@@ -84,13 +84,13 @@ void ITick.Tick(Actor self)
 			for (var i = 0; i < delayedActions.Count; i++)
 			{
 				var x = delayedActions[i];
-				if (--x.First <= 0)
-					x.Second();
+				if ((x.Key - 1) <= 0)


This looks like we never decrease the key at all?

abcdefg30 · 2021-04-03T21:39:43Z

Sorry, I don't think merging this as-is is a good idea. We should first update the ModSDK files only, and then in a second step update the mod to use the latest release.

MustaphaTR · 2021-04-04T09:10:19Z

We should first update the ModSDK files only, and then in a second step update the mod to use the latest release.

I don't think that is a good idea, changes to SDK are tied to the changes to the engine. Unless you mean it as 2 seperate commits in the same PR. Updating them without other, regardless of the order, would break stuff.

Mailaender · 2021-07-19T15:28:27Z

What I do for @OpenHV is not to make huge jumps between releases, but change it in small weekly engine updates based on single commits. Even smaller steps for larger engine changes. This makes those undertakings a lot more digestible and less painful. Oftentimes you only need to go 10 commits ahead to power that latest engine feature/interface you are depending on. As a release on this mod is nowhere near in sight you can keep it on an "unstable" engine version and with @OpenRA's slow development process with huge veto powers those untagged commits can be sufficiently stable even for test releases.

abcdefg30 · 2021-10-04T10:05:14Z

Closing as superseded by #778. Thanks for the effort, though.

kienanstewart added 9 commits January 21, 2021 23:24

Remove MaxMind.dll - fixes windows build

b2edaec

Fix macosx build

78c7427

Copy dylibs from engine to package for MacOS

7e5344d

Fixes running the game when the dylib's aren't found in the system path

Start of engine update to playtest-20201213

1309141

Fix content loading

8faa0de

Replace SelfHealing with ChangesHealth

94b173a

Add dimensions and footprint for chronosphere and iron curtain

a760065

Add placeholder entries in chrome.yaml to load menu

4e74dcc

Fix crash loading streams from audio bag

cf99405

Add capacity pips to harvesters

92f1d0a

kienanstewart added 6 commits January 27, 2021 21:50

Add default cargo pips back for vehicles that require them

74c9576

Update FacingTolerance to match WAngle extents

ccbad9f

Rename ValidStaqnces to ValidRelationships

708da9a

Update InitialFacing and PreviewFacing

e04612c

Update TurnSpeed

a646203

Fix crash when Nighthawk attacks

d232678

kienanstewart added 10 commits January 28, 2021 22:49

Fix dock angle's for refineries

9780675

Update Facing values

527b1d4

Replace Left/Right Color with Min/Max Color

c667662

Fixes minimaps

Remove MuzzleSplitFacings

d041776

Replace AmmoPool/PipCount with WithAmmomPipsDecoration

31ccac8

Use yellow pips for ore in harvesters

f11f65d

Use inherited cargopips definition for transports

2558a87

Fixes crashes when loading infantry with CustomPipType set into transports

Fix destroyers attacking with osprey

0b6fdb2

Replace all ReferencePoint with Position

cdcd9ff

Fixes a number of decoration display issues

Add selection decorations back to vehicles

f76e88c

kienanstewart added 9 commits January 31, 2021 11:20

Rename SmokeType and SmokePercentage

f18a779

Rename DisplayTimerStances to DisplayTimeRelationships

d450377

Replace FlashType with FlashPaletteEffect for nukes

cb7aeaa

Replace Notification with InfiltratedNotification

5650540

Allow null images for a number of projectile sequences

fcce71e

Fix missing muzzle on allied fv

3d7b373

Fix warning about missing animation for dog DefaultAttackSequence

7a466bc

Fix last warnings from test command

02be2f4

Fix frame-end behaviour for carrier parents (eg. destroyers)

09a3413

pgwipeout suggested changes Feb 2, 2021

View reviewed changes

kienanstewart added 6 commits February 2, 2021 12:50

Import OpenRAModSDK changes since 20200503

c722267

Copy glyphs.png from RA temporarily

20f09d5

Ignore .so files everywhere

ad2ff61

Add scaled glyphs from RA

c1a46d3

Updated chrome.yaml to use them for some decorations that weren't working properly.

Fix harvester pip colouration

51f50b0

Fix pip colours for transports

d0555ef

kienanstewart changed the title ~~WIP: update engine to playtest 20201213~~ Update engine to playtest 20201213 Feb 2, 2021

abcdefg30 reviewed Apr 3, 2021

View reviewed changes

penev92 mentioned this pull request Jul 19, 2021

Updated ModSDK scripts from various old versions to release-20200503 #777

Merged

abcdefg30 closed this Oct 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update engine to playtest 20201213 #764

Update engine to playtest 20201213 #764

kienanstewart commented Jan 26, 2021 •

edited

Loading

kienanstewart commented Jan 27, 2021 •

edited

Loading

abcdefg30 commented Jan 27, 2021

kienanstewart commented Jan 28, 2021

pgwipeout commented Jan 30, 2021 •

edited

Loading

pgwipeout left a comment •

edited

Loading

pgwipeout Feb 2, 2021

kienanstewart Feb 2, 2021

pgwipeout Feb 2, 2021

pgwipeout Feb 2, 2021

pgwipeout Feb 2, 2021

kienanstewart Feb 2, 2021

pgwipeout Feb 2, 2021

pgwipeout commented Feb 2, 2021

kienanstewart commented Feb 2, 2021

pgwipeout commented Feb 2, 2021

kienanstewart commented Feb 2, 2021

Mailaender commented Apr 3, 2021

LinuxDonald commented Apr 3, 2021

abcdefg30 Apr 3, 2021

abcdefg30 commented Apr 3, 2021

MustaphaTR commented Apr 4, 2021 •

edited

Loading

Mailaender commented Jul 19, 2021

abcdefg30 commented Oct 4, 2021

Update engine to playtest 20201213 #764

Update engine to playtest 20201213 #764

Conversation

kienanstewart commented Jan 26, 2021 • edited Loading

kienanstewart commented Jan 27, 2021 • edited Loading

abcdefg30 commented Jan 27, 2021

kienanstewart commented Jan 28, 2021

pgwipeout commented Jan 30, 2021 • edited Loading

pgwipeout left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgwipeout commented Feb 2, 2021

kienanstewart commented Feb 2, 2021

pgwipeout commented Feb 2, 2021

kienanstewart commented Feb 2, 2021

Mailaender commented Apr 3, 2021

LinuxDonald commented Apr 3, 2021

Choose a reason for hiding this comment

abcdefg30 commented Apr 3, 2021

MustaphaTR commented Apr 4, 2021 • edited Loading

Mailaender commented Jul 19, 2021

abcdefg30 commented Oct 4, 2021

kienanstewart commented Jan 26, 2021 •

edited

Loading

kienanstewart commented Jan 27, 2021 •

edited

Loading

pgwipeout commented Jan 30, 2021 •

edited

Loading

pgwipeout left a comment •

edited

Loading

MustaphaTR commented Apr 4, 2021 •

edited

Loading