Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added terror drone interaction with vehicles #709

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mailaender
Copy link
Member

Closes #148.

@sorcerer86pt
Copy link

sorcerer86pt commented May 2, 2020

It's missing one thing: Terror drone infection should be removed if the tank goes to a repair pad, and it starts repairing. Also if a tank is affected by iron curtain, the terror drone should be destroyed. If the tanks is chrono shifted, the terror done is left behind ( the same for the chronominer teleporting to ore refinery)

The infecting part and damage is working.

Copy link

@sorcerer86pt sorcerer86pt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Implemente repair pad terror drone removal logic
  • Implement terror drone left behind by chrono effects
  • Implement terror drone destruction on iron curtain

@Mailaender
Copy link
Member Author

The drone repair removal will work once the engine is updated to OpenRA/OpenRA#17721.

Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't quite understand the "joust" terminology, where is the connection to medieval tournaments?

OpenRA.Mods.RA2/Traits/AttackInfect.cs Outdated Show resolved Hide resolved
OpenRA.Mods.RA2/Traits/AttackInfect.cs Outdated Show resolved Hide resolved
@Mailaender
Copy link
Member Author

I still don't quite understand the "joust" terminology, where is the connection to medieval tournaments?

They probably meant diving as in German "hechten", but it isn't in any dictionary? Changed it to jumping now which everyone will understand.

@sorcerer86pt
Copy link

sorcerer86pt commented Jul 23, 2020 via email

@Mailaender
Copy link
Member Author

Updated.

@Mailaender
Copy link
Member Author

Rebased.

@Mailaender
Copy link
Member Author

Added support for Terror Drone removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terror drones
5 participants