Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: syft error handling #8883

Merged
merged 366 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
366 commits
Select commit Hold shift + click to select a range
0bff759
refactor: wrap _get_api
tcp Jul 5, 2024
06554cd
refactor: notebook #3 is passing
tcp Jul 5, 2024
40ab151
fix part of nb
koenvanderveen Jul 5, 2024
452ba17
tests(user_service): all tests pass
tcp Jul 5, 2024
ba5ff8a
fix some tests
koenvanderveen Jul 5, 2024
84a9a12
Merge branch 'refactor/syft-error-handling-services' of github.com:Op…
koenvanderveen Jul 5, 2024
6665476
tests(worker_test): all tests are passing
tcp Jul 5, 2024
215b918
fix tests
koenvanderveen Jul 5, 2024
cf1b95b
Merge branch 'refactor/syft-error-handling-services' of github.com:Op…
koenvanderveen Jul 5, 2024
1ec7eb4
tests(user): user_stash and user_test are passing
tcp Jul 5, 2024
aa1e3f3
tests(settings): settings tests are passing
tcp Jul 5, 2024
189524c
fix: unwrap calls with new message
tcp Jul 8, 2024
56903f3
queue stash
koenvanderveen Jul 8, 2024
1dcfe72
tests(dataset): dataset tests are passing
tcp Jul 8, 2024
15df847
fix tests
koenvanderveen Jul 9, 2024
4d3f35d
Merge branch 'refactor/syft-error-handling-services' of github.com:Op…
koenvanderveen Jul 9, 2024
631a798
fix tests
koenvanderveen Jul 9, 2024
fb26705
fix tests
koenvanderveen Jul 9, 2024
83aa179
fix tests
koenvanderveen Jul 9, 2024
fc8e16e
fix tests
koenvanderveen Jul 9, 2024
c1f3a6a
fix: remove stray as_result call in queue_stash
tcp Jul 9, 2024
ea4d0a2
add server and client traceback to syftexception
abyesilyurt Jul 9, 2024
fd1f6e2
Merge branch 'refactor/syft-error-handling-services' of github.com:Op…
abyesilyurt Jul 9, 2024
a20aafc
tests: fix notebook_ui and refix user_test
tcp Jul 9, 2024
6653c27
tests(blob_storage): fix BlobStorageService delete test
tcp Jul 9, 2024
f39afa5
tests(eager): eager_test is green
tcp Jul 9, 2024
5f1dc67
tests(requests): request_stash and request_code_accept_deny are green
tcp Jul 9, 2024
c1bd69b
fix(lib_endpoints): unwraps SyftSuccess for lib endpoints
tcp Jul 9, 2024
d716a72
fix: return for _run in CreateCustomWorkerPoolChange
tcp Jul 9, 2024
24f5168
fix: handle SyftError in lib endpoints
tcp Jul 9, 2024
9e7dfb6
wip: fix: upload_dataset in domain_client
tcp Jul 9, 2024
cb2fa27
move syftexception html to jinja template
abyesilyurt Jul 10, 2024
e4e7dc8
Merge remote-tracking branch 'origin/refactor/syft-error-handling-ser…
abyesilyurt Jul 10, 2024
d7af0d9
merge patch
koenvanderveen Jul 10, 2024
1ac9c15
protocol
koenvanderveen Jul 10, 2024
8ce6f4f
lint
koenvanderveen Jul 10, 2024
418dfe7
first 6 notebooks
koenvanderveen Jul 10, 2024
9dbb974
feat: remove javascript, clean trace prior to showing
tcp Jul 10, 2024
e72c903
last 6 notebooks
koenvanderveen Jul 10, 2024
ad252a2
merge
koenvanderveen Jul 10, 2024
f5180cc
Merge pull request #9030 from OpenMined/syft-exception-repr
koenvanderveen Jul 10, 2024
574120f
delete notebooks
koenvanderveen Jul 10, 2024
f913eef
Merge branch 'refactor/syft-error-handling-services' of github.com:Op…
koenvanderveen Jul 10, 2024
1f9051e
fix conditional stacktraces
koenvanderveen Jul 10, 2024
1c63437
fix conditional stacktraces
koenvanderveen Jul 10, 2024
a4791e2
api service
teo-milea Jul 11, 2024
6aadc83
attestation service
teo-milea Jul 11, 2024
3a2d09e
notification service
teo-milea Jul 11, 2024
8a923f1
migration service
teo-milea Jul 11, 2024
c2eb9b2
worker related services
teo-milea Jul 11, 2024
41b4917
save progress on network service
teo-milea Jul 11, 2024
d688ba2
finish network
teo-milea Jul 11, 2024
1464603
fix problems
koenvanderveen Jul 11, 2024
bd68cdd
error handling of create or update
koenvanderveen Jul 11, 2024
4be2796
small changes
koenvanderveen Jul 11, 2024
c0875a7
stash updates
koenvanderveen Jul 11, 2024
a98c4d3
error handling for query one
koenvanderveen Jul 11, 2024
c782aa3
Merge branch 'refactor/syft-error-handling-services' into refactor/sy…
koenvanderveen Jul 11, 2024
f675bd0
Merge pull request #9040 from OpenMined/refactor/syft-error-handling-…
koenvanderveen Jul 11, 2024
f83325a
remove old stashes
koenvanderveen Jul 11, 2024
2047d05
refactor resolve link
koenvanderveen Jul 11, 2024
c08c200
rm output
koenvanderveen Jul 11, 2024
aab90f6
merge
koenvanderveen Jul 11, 2024
dc4a166
clean nb
koenvanderveen Jul 11, 2024
8bd7bcf
release folder
koenvanderveen Jul 11, 2024
b07c473
fix node startup
koenvanderveen Jul 11, 2024
b06ba39
fix model
eelcovdw Jul 12, 2024
c0beea6
fix sync tests
teo-milea Jul 12, 2024
7bf2dd2
tests: all notification tests are green
tcp Jul 12, 2024
9bce58a
fix code, user, request, settings
eelcovdw Jul 12, 2024
bed4123
Merge branch 'refactor/syft-error-handling-services' of github.com:Op…
eelcovdw Jul 12, 2024
4aea309
fix notebook_ui
eelcovdw Jul 12, 2024
2eec68c
tests: base stash test is passing
tcp Jul 12, 2024
a9c1964
fixed some tests
teo-milea Jul 12, 2024
493a13d
Merge branch 'refactor/syft-error-handling-services' of github.com:Op…
teo-milea Jul 12, 2024
c068918
tests: all tests are green
tcp Jul 12, 2024
b1669db
Merge remote-tracking branch 'origin/dev' into refactor/syft-error-ha…
tcp Jul 12, 2024
1501092
Merge pull request #9018 from OpenMined/refactor/syft-error-handling-…
tcp Jul 12, 2024
151d26d
fix: indent
tcp Jul 12, 2024
27d8e35
fix: merge remains
tcp Jul 12, 2024
6d09d7c
tests: one left
tcp Jul 13, 2024
cb37a6a
lint: part 1
tcp Jul 13, 2024
2204594
lint: started mypy
tcp Jul 13, 2024
9674c5f
fix test
koenvanderveen Jul 15, 2024
6174f7f
lint: mypy is now a friend, but not of the notebooks
tcp Jul 15, 2024
7625105
tests: unit tests are green
tcp Jul 15, 2024
4c4142a
lint: tox
tcp Jul 15, 2024
494fc58
Merge remote-tracking branch 'origin/dev' into refactor/syft-error-ha…
tcp Jul 15, 2024
42c3571
Merge remote-tracking branch 'origin/dev' into refactor/syft-error-ha…
tcp Jul 15, 2024
71b78f9
save progress
teo-milea Jul 17, 2024
22bfcd6
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
teo-milea Jul 17, 2024
625bb69
Merge remote-tracking branch 'refs/remotes/origin/refactor/syft-error…
tcp Jul 17, 2024
00c2f28
Merge remote-tracking branch 'origin/dev' into refactor/syft-error-ha…
tcp Jul 17, 2024
9fa7d60
some dev fixes
tcp Jul 18, 2024
8622e41
more dev fixes; permission issues with action object
tcp Jul 18, 2024
b886f54
removed most SyftError, is_err, err, is_ok, ok
teo-milea Jul 24, 2024
8ef0152
Merge branch 'refactor/syft-error-handling-dev-conflicts' of github.c…
teo-milea Jul 24, 2024
e098fc8
fix lint
teo-milea Jul 24, 2024
a877447
Merge branch 'dev' of github.com:OpenMined/PySyft into refactor/syft-…
teo-milea Jul 24, 2024
62db173
fix new syfterrors
teo-milea Jul 24, 2024
99a7356
save progress
teo-milea Jul 24, 2024
9ee4af0
Merge branch 'dev' into refactor/syft-error-handling
teo-milea Jul 26, 2024
dd312ed
save progress
teo-milea Jul 31, 2024
9e3bc66
remove old hagrid
teo-milea Jul 31, 2024
61403de
Merge branch 'dev' of github.com:OpenMined/PySyft into refactor/syft-…
teo-milea Jul 31, 2024
d4ebe3e
Merge remote-tracking branch 'origin/dev' into refactor/syft-error-ha…
tcp Aug 1, 2024
de8fb99
fix: unwrap ck_check
tcp Aug 1, 2024
974c09d
fix: can_write in kv_docstore
tcp Aug 1, 2024
e4a72e0
fix: removing some new SyftErrors
tcp Aug 1, 2024
248a718
fix: updated some api_for calls
tcp Aug 1, 2024
e40d721
other small fixes
tcp Aug 1, 2024
8872715
fix: rename _api_for back to api_for
tcp Aug 1, 2024
c6941be
Merge remote-tracking branch 'origin/dev' into refactor/syft-error-ha…
tcp Aug 6, 2024
051c0fd
fix: merge conflict
tcp Aug 13, 2024
cd5317f
fix bugs
koenvanderveen Aug 13, 2024
8a0bcf9
fix tests
koenvanderveen Aug 13, 2024
3c3c0eb
fix tests
koenvanderveen Aug 13, 2024
782470e
fix: bogus is_ok in store fixture, mongo collection. remove some prints
tcp Aug 13, 2024
3733253
fix: sqlite raise_exception only returns the message now, unwrap in d…
tcp Aug 13, 2024
f34df70
fix tests
koenvanderveen Aug 13, 2024
18d6cfb
fix tests
koenvanderveen Aug 13, 2024
b96c638
fix tests
koenvanderveen Aug 13, 2024
afeeca8
fix tests
koenvanderveen Aug 13, 2024
a2bc928
fix: sqlite doc store creates table if not exists
tcp Aug 13, 2024
56cfaee
fix tests
koenvanderveen Aug 13, 2024
d7a1887
fix tests
koenvanderveen Aug 13, 2024
79740ce
fix tests
koenvanderveen Aug 13, 2024
98c57ec
fix: base_stash tests
tcp Aug 13, 2024
5bdee64
fix: kv_document_store test
tcp Aug 13, 2024
146e546
fix: worker_pool tests
tcp Aug 13, 2024
2df03b9
fix tests
koenvanderveen Aug 13, 2024
c2c39be
fix: more tests
tcp Aug 13, 2024
a60519a
fix: user_test and user_stash_test
tcp Aug 13, 2024
e6b5506
fix: test_project_serde
tcp Aug 13, 2024
7f76254
fix: let admins create projects too
tcp Aug 13, 2024
ff4d5ed
fix: add server_uid and user_verify_key to SyftBaseObject get_api
tcp Aug 13, 2024
94681f3
fix: diff_state now passes right keys to get_api
tcp Aug 13, 2024
e2303f3
fix: remove prints from policy
tcp Aug 13, 2024
10b0344
fix: some cleaning up, might break things outside diff
tcp Aug 13, 2024
305b362
revert some server code, down to 20
tcp Aug 13, 2024
66d0c18
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 14, 2024
174c951
fix: add unwrap and as_root_context to flatten_action_arg
tcp Aug 14, 2024
d8446f0
fix: add root_context when a new ao is created in flatten_action_arg
tcp Aug 14, 2024
cafc356
fix debugging in pytest
koenvanderveen Aug 14, 2024
bf33038
merge
koenvanderveen Aug 14, 2024
ba59e86
fix test
koenvanderveen Aug 14, 2024
f29fc1a
fix tests
tcp Aug 14, 2024
34c5a43
remove dead code
tcp Aug 14, 2024
7e0e399
fix settings service test
tcp Aug 14, 2024
16a9985
fix: user_service_test
tcp Aug 14, 2024
624ca0b
fix test
koenvanderveen Aug 14, 2024
3406002
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 14, 2024
df14a51
fix test
koenvanderveen Aug 14, 2024
519ab3d
fix test
koenvanderveen Aug 14, 2024
f68b819
fix test
koenvanderveen Aug 14, 2024
001356d
fix: user_code_test
tcp Aug 14, 2024
59d3a48
fix: notification_stash_test
tcp Aug 14, 2024
7ceb048
fix: job_stash_test
tcp Aug 14, 2024
2c7c456
fix test
koenvanderveen Aug 14, 2024
347bcb0
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 14, 2024
5adc8cf
fix test
koenvanderveen Aug 14, 2024
3baf15d
fix: remaining tests
tcp Aug 14, 2024
e9c2153
merge conflicts
koenvanderveen Aug 15, 2024
5158196
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 15, 2024
fbaeee0
fix conflicts
koenvanderveen Aug 15, 2024
1e19a0c
fix: actionobject error msg
tcp Aug 15, 2024
9e26c0d
fix conflicts
koenvanderveen Aug 15, 2024
1e18a98
fix: user test
tcp Aug 15, 2024
02f39b9
fix reload_cache
eelcovdw Aug 15, 2024
7bb7430
fix: get_settings fix
tcp Aug 15, 2024
72ddced
fix: grid image in settings
tcp Aug 15, 2024
79d067a
fix: more tidyings
tcp Aug 15, 2024
71dc1cd
fix: more tidyings
tcp Aug 15, 2024
f7dfa07
another batch of fixes
tcp Aug 16, 2024
a901f98
fix: jobs are picked up
tcp Aug 16, 2024
8e6417a
fix: jobs with errors
tcp Aug 16, 2024
aa63f14
Merge remote-tracking branch 'origin/dev' into refactor/syft-error-ha…
tcp Aug 19, 2024
b0b418f
lint
tcp Aug 19, 2024
2391062
lint: we're close to being friends with ruff
tcp Aug 19, 2024
a3ad709
fix some lint tests
teo-milea Aug 19, 2024
5e8b036
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
teo-milea Aug 19, 2024
92b89d9
fix some more tests
teo-milea Aug 20, 2024
b245767
fix tests
koenvanderveen Aug 21, 2024
87d96cf
fix: import Path in server/uvicorn
tcp Aug 21, 2024
8120abb
fix job errors
tcp Aug 21, 2024
7b163b3
lint
koenvanderveen Aug 21, 2024
ceb0da1
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 21, 2024
3ae5e64
lint
koenvanderveen Aug 21, 2024
818883f
undo prettier single quotes
koenvanderveen Aug 21, 2024
acd3550
fix notebook tests
koenvanderveen Aug 21, 2024
a69a5c0
fix kernel spec
koenvanderveen Aug 21, 2024
a118cbf
fix: custom function api.view
tcp Aug 21, 2024
1de1161
fix nb
koenvanderveen Aug 21, 2024
c8dc189
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 21, 2024
76519be
feat: remove third-party result lib
tcp Aug 21, 2024
5cac981
feat: remove old SyftException
tcp Aug 21, 2024
394fb92
feat: replace SyftAttributeError with AttributeError
tcp Aug 21, 2024
de55a59
fix job stash repr
tcp Aug 22, 2024
a5e4ee0
nb fixes
koenvanderveen Aug 22, 2024
e0d9488
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 22, 2024
491a7ed
first fix
koenvanderveen Aug 22, 2024
f5c0c63
nb 12 fix
koenvanderveen Aug 22, 2024
b9ade6f
fix notebook tests
koenvanderveen Aug 22, 2024
0396789
fix notebook tests
koenvanderveen Aug 22, 2024
fad7840
fix worker service, fix security issue
koenvanderveen Aug 23, 2024
ffeb584
fix linting
koenvanderveen Aug 23, 2024
15799d9
fix linting
koenvanderveen Aug 23, 2024
ae42471
Merge branch 'dev' of github.com:OpenMined/PySyft into refactor/syft-…
koenvanderveen Aug 23, 2024
90a963e
fix integrations tests
koenvanderveen Aug 23, 2024
2a2b286
lint
koenvanderveen Aug 23, 2024
3d36805
debug linter
koenvanderveen Aug 25, 2024
c1187d8
merge dev
koenvanderveen Aug 25, 2024
bdf2779
ci
koenvanderveen Aug 25, 2024
2936418
ci
koenvanderveen Aug 25, 2024
0db4a75
linting
koenvanderveen Aug 25, 2024
8555469
linting
koenvanderveen Aug 25, 2024
3959ad2
linting
koenvanderveen Aug 25, 2024
56d5f7f
linting
koenvanderveen Aug 25, 2024
b499d70
fix k8s startup
koenvanderveen Aug 25, 2024
31b6f78
fix k8s container nb
koenvanderveen Aug 25, 2024
1ba6b0f
fix EnclaveMedata schema problem
koenvanderveen Aug 25, 2024
72623e0
fix some unwraps in network and server
tcp Aug 26, 2024
b14f153
lint
tcp Aug 26, 2024
0f3d915
Merge branch 'dev' into refactor/syft-error-handling
koenvanderveen Aug 26, 2024
1083b6d
fix: gateway_test
tcp Aug 26, 2024
2ff19da
lint
tcp Aug 26, 2024
22170b0
fix partition by node
koenvanderveen Aug 26, 2024
e50addd
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 26, 2024
0d953df
fix remove existing peers
koenvanderveen Aug 26, 2024
edeae67
fix: unwraps in gateway_test
tcp Aug 26, 2024
5b0615a
fix gateway test
tcp Aug 26, 2024
5a28df4
fix race condition in get all
koenvanderveen Aug 26, 2024
51849d1
fix: delete_peer_by_id unwrap
tcp Aug 26, 2024
c6aea2e
fix unwrapping in network service
koenvanderveen Aug 26, 2024
e9719b9
fix mongo get
koenvanderveen Aug 26, 2024
385ff6b
patch mongo get problem
koenvanderveen Aug 26, 2024
d30c700
fix container test problems
koenvanderveen Aug 26, 2024
ef829e6
Merge branch 'dev' into refactor/syft-error-handling
koenvanderveen Aug 26, 2024
6f4c909
fix: unwraps in blob_storage and SyftException in builder_k8s
tcp Aug 26, 2024
7582159
tmp change in tox
koenvanderveen Aug 26, 2024
c34fb43
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 26, 2024
a7ca507
linting
koenvanderveen Aug 26, 2024
5d8ece8
reverse
koenvanderveen Aug 26, 2024
72ce64d
add roles for job.get_all
teo-milea Aug 26, 2024
1a2bd2d
Merge pull request #9208 from OpenMined/refactor/syft-error-handling_…
koenvanderveen Aug 26, 2024
959b2f4
fix problems with pool test
koenvanderveen Aug 26, 2024
b539a35
Merge branch 'refactor/syft-error-handling' of github.com:OpenMined/P…
koenvanderveen Aug 26, 2024
f746e9b
fix problems with pool test
koenvanderveen Aug 26, 2024
e0f0e69
fix problems with pool test
koenvanderveen Aug 26, 2024
8dd7b0d
fix problems with pool test
koenvanderveen Aug 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"singleQuote": false
}
17 changes: 3 additions & 14 deletions notebooks/api/0.8/00-load-data.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@
"outputs": [],
"source": [
"# Launch a fresh datasite server named \"test-datasite-1\" in dev mode on the local machine\n",
"server = sy.orchestra.launch(\n",
" name=\"test-datasite-1\", port=\"auto\", dev_mode=True, reset=True\n",
")"
"server = sy.orchestra.launch(name=\"test-datasite-1\", dev_mode=True, reset=True)"
]
},
{
Expand Down Expand Up @@ -609,11 +607,7 @@
},
{
"cell_type": "markdown",
"metadata": {
"jupyter": {
"source_hidden": true
}
},
"metadata": {},
"source": [
"### Reading the Syft Dataset from Datasite Server\n",
"\n",
Expand Down Expand Up @@ -717,11 +711,6 @@
}
],
"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
"language_info": {
"codemirror_mode": {
"name": "ipython",
Expand All @@ -732,7 +721,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.5"
"version": "3.12.5"
},
"toc": {
"base_numbering": 1,
Expand Down
39 changes: 6 additions & 33 deletions notebooks/api/0.8/01-submit-code.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"outputs": [],
"source": [
"# third party\n",
"import pandas as pd\n",
"\n",
"# syft absolute\n",
"import syft as sy\n",
Expand Down Expand Up @@ -222,18 +221,7 @@
"metadata": {},
"outputs": [],
"source": [
"# cannot access the private data\n",
"asset.data"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"# Test\n",
"assert not isinstance(asset.data, pd.DataFrame) # returns a permission error"
"assert asset.data is None"
]
},
{
Expand Down Expand Up @@ -461,7 +449,8 @@
"outputs": [],
"source": [
"# create the same code request with the exact same function should return an error\n",
"result = new_project.create_code_request(sum_trade_value_mil, jane_client)"
"with sy.raises(sy.SyftException, show=True):\n",
" result = new_project.create_code_request(sum_trade_value_mil, jane_client)"
]
},
{
Expand Down Expand Up @@ -537,19 +526,8 @@
},
"outputs": [],
"source": [
"result = jane_client.code.sum_trade_value_mil(trade_data=asset)\n",
"result"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"tags": []
},
"outputs": [],
"source": [
"assert isinstance(result, sy.SyftError)"
"with sy.raises(sy.SyftException, show=True):\n",
" jane_client.code.sum_trade_value_mil(trade_data=asset)"
]
},
{
Expand Down Expand Up @@ -584,11 +562,6 @@
}
],
"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
"language_info": {
"codemirror_mode": {
"name": "ipython",
Expand All @@ -599,7 +572,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.13"
"version": "3.12.5"
},
"toc": {
"base_numbering": 1,
Expand Down
7 changes: 1 addition & 6 deletions notebooks/api/0.8/02-review-code-and-approve.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -486,11 +486,6 @@
}
],
"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
"language_info": {
"codemirror_mode": {
"name": "ipython",
Expand All @@ -501,7 +496,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.4"
"version": "3.12.5"
},
"toc": {
"base_numbering": 1,
Expand Down
20 changes: 12 additions & 8 deletions notebooks/api/0.8/03-data-scientist-download-result.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@
"As the Syft Function policy requires exact input match, let's get the asset for which we wanted to run our function on."
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"datasite_client.datasets"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down Expand Up @@ -189,8 +198,8 @@
},
"outputs": [],
"source": [
"assert isinstance(ops.is_valid, sy.SyftError)\n",
"assert ops.count > 0"
"assert not ops.is_valid\n",
"assert ops.count().unwrap() > 0"
]
},
{
Expand All @@ -216,11 +225,6 @@
}
],
"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
"language_info": {
"codemirror_mode": {
"name": "ipython",
Expand All @@ -231,7 +235,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.16"
"version": "3.12.5"
},
"toc": {
"base_numbering": 1,
Expand Down
7 changes: 1 addition & 6 deletions notebooks/api/0.8/04-pytorch-example.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -403,11 +403,6 @@
}
],
"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
"language_info": {
"codemirror_mode": {
"name": "ipython",
Expand All @@ -418,7 +413,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.1.-1"
"version": "3.12.5"
},
"toc": {
"base_numbering": 1,
Expand Down
Loading
Loading