-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: syft error handling #8883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eelcovdw
reviewed
Jun 2, 2024
eelcovdw
reviewed
Jun 2, 2024
eelcovdw
reviewed
Jun 2, 2024
eelcovdw
reviewed
Jun 2, 2024
madhavajay
reviewed
Jun 13, 2024
from ..service.context import AuthedServiceContext | ||
from ..service.user.user_roles import ServiceRole | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we send this between worker and backend or other nodes?
Should we consider having a single message exception and then keeping the public / private as kind of twin somewhere?
4 tasks
This was referenced Jul 3, 2024
…enMined/PySyft into refactor/syft-error-handling-services
…enMined/PySyft into refactor/syft-error-handling-services
…ySyft into refactor/syft-error-handling
koenvanderveen
changed the title
wip: refactor: syft error handling
Refactor: syft error handling
Aug 26, 2024
…ySyft into refactor/syft-error-handling
…fix-jobs add roles for job.get_all
…ySyft into refactor/syft-error-handling
koenvanderveen
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves error handling in PySyft by implementing our own result and custom exception.
Proposed changelist for this PR:
refactor(syft_exc): replace
PySyftException
withSyftException
#8919feat(syft_exc): change client and server side response handling #9012
feat(syft_exc): add implementation of BaseStash and BaseUIDStoreStash using the new types #9013
Refactor/syft error handling services #9018
SyftException
in service/response.pySyftResponseMessage
subclassesRelated PRs
PySyftException
withSyftException
#8919Notable changes (TODO)
How has this been tested?
Checklist