Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: syft error handling #8883

Merged
merged 366 commits into from
Aug 26, 2024
Merged

Refactor: syft error handling #8883

merged 366 commits into from
Aug 26, 2024

Conversation

tcp
Copy link
Collaborator

@tcp tcp commented Jun 2, 2024

Description

Improves error handling in PySyft by implementing our own result and custom exception.

Proposed changelist for this PR:

Related PRs

Notable changes (TODO)

  • {client,server}-side handling of service results
  • error handling of client-side methods

How has this been tested?

  • Added new tests for Result
  • Added new tests for SyftException
  • Added tests for ExceptionFilter
  • Updated tests
  • Current tests are green

Checklist

@tcp tcp self-assigned this Jun 3, 2024
@tcp tcp changed the title wip: refactor: syft error handling refactor: syft error handling Jun 12, 2024
from ..service.context import AuthedServiceContext
from ..service.user.user_roles import ServiceRole


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we send this between worker and backend or other nodes?
Should we consider having a single message exception and then keeping the public / private as kind of twin somewhere?

@tcp tcp changed the title refactor: syft error handling wip: refactor: syft error handling Jun 13, 2024
@tcp tcp marked this pull request as draft June 13, 2024 23:28
@koenvanderveen koenvanderveen changed the title wip: refactor: syft error handling Refactor: syft error handling Aug 26, 2024
@koenvanderveen koenvanderveen merged commit 755a4db into dev Aug 26, 2024
27 checks passed
@koenvanderveen koenvanderveen deleted the refactor/syft-error-handling branch August 26, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants