Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for HTTP Request Tracing #6966

Closed
1 of 2 tasks
fmhwong opened this issue Oct 11, 2023 · 3 comments
Closed
1 of 2 tasks

Documentation for HTTP Request Tracing #6966

fmhwong opened this issue Oct 11, 2023 · 3 comments

Comments

@fmhwong
Copy link
Member

fmhwong commented Oct 11, 2023

Feature epic details

Operating systems

Does the documentation apply to all operating systems?

  • Yes
  • No; specify operating systems: ______

Summary

Provide a concise summary of your feature. What is the update, why does it matter, and to whom? What do 80% of target users need to know to be most easily productive using your runtime update?

Configuration

List any new or changed properties, parameters, elements, attributes, etc. Include default values and configuration examples where relevant:

Feature is automatically enabled when mpTelemetry-1.0 and mpTelemetry-1.1 is enabled. No new configuration.

Updates to existing topics

To update existing topics, specify a link to the topics that are affected. Include a copy of the current text and the exact text to which it will change. For example: Change ABC to XYZ

In this page https://openliberty.io/docs/latest/microprofile-telemetry.html, under the "Automatic Instrumentation" section. Add the following line.

Starting in 23.0.0.11, spans will be automatically created for incoming HTTP requests such as static files, servlets and JSPs.

@ramkumar-k-9286
Copy link
Contributor

ramkumar-k-9286 commented Oct 20, 2023

@fmhwong @dmuelle

Hi Felix.

Added the suggested information into the document. Made minor changes to the suggested information.

Also, placed the information towards the beginning of the Automatic Instrumentation section to ensure that the audience is immediately aware of this information when learning about automatic instrumentation.

Draft Link: https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/microprofile-telemetry.html

Please review the same and add the Developer Reviewed label if you are happy with the change.

Regards,
Ramkumar

@fmhwong
Copy link
Member Author

fmhwong commented Oct 26, 2023

FYI, there was an issue of mpTelemetry running with InstantOn so we reverting the beta fencing in 23.0.0.11. We are targeting 23.0.0.12 now.

@dmuelle dmuelle modified the milestones: 23.0.0.11, 23.0.0.12 Oct 26, 2023
@dmuelle
Copy link
Member

dmuelle commented Nov 28, 2023

Closing this issue as the content is in the telemetry file, which will get technical and peer review as part of #6776 . The changes in this issue are in the same branch as those updates and will be delivered to vNext when that branch is merged.

@dmuelle dmuelle closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants