Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of MicroProfile Telemetry 1.1 #6776

Closed
yasmin-aumeeruddy opened this issue Jul 12, 2023 · 5 comments · Fixed by #7130
Closed

Documentation of MicroProfile Telemetry 1.1 #6776

yasmin-aumeeruddy opened this issue Jul 12, 2023 · 5 comments · Fixed by #7130
Assignees
Labels
23.0.0.12 peer reviewed technical reviewed An SME reviewed and approved the documentation from a technical perspective.
Milestone

Comments

@yasmin-aumeeruddy
Copy link
Member

Epic: OpenLiberty/open-liberty#25187

Content: TBD

Currently targeting 230010-beta/ 230012 GA

@dmuelle dmuelle added this to the 23.0.0.11 milestone Sep 20, 2023
@dmuelle dmuelle modified the milestones: 23.0.0.11, 23.0.0.12 Oct 18, 2023
@yasmin-aumeeruddy
Copy link
Member Author

Content is now in #7033 and #7054

dmuelle added a commit that referenced this issue Nov 28, 2023
dmuelle added a commit that referenced this issue Nov 29, 2023
dmuelle added a commit that referenced this issue Nov 29, 2023
@dmuelle dmuelle mentioned this issue Nov 29, 2023
dmuelle added a commit that referenced this issue Nov 29, 2023
@dmuelle dmuelle mentioned this issue Nov 29, 2023
dmuelle added a commit that referenced this issue Nov 30, 2023
@dmuelle dmuelle mentioned this issue Nov 30, 2023
dmuelle added a commit that referenced this issue Nov 30, 2023
@dmuelle dmuelle mentioned this issue Nov 30, 2023
@dmuelle
Copy link
Member

dmuelle commented Nov 30, 2023

Hi @yasmin-aumeeruddy - the updated draft for this feature is now ready for review:

https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/microprofile-telemetry.html

I made some changes to the overall structure to reduce repetition and make the page easier to navigate, but the information should be the same as the original PRs. If any further edits are needed, just let me know. When you're satisfied with the topic, you can add the technical reviewed label to sign off and the update will publish with 23.0.0.12. Thanks!

@yasmin-aumeeruddy yasmin-aumeeruddy added the technical reviewed An SME reviewed and approved the documentation from a technical perspective. label Dec 4, 2023
dmuelle added a commit that referenced this issue Dec 4, 2023
@dmuelle
Copy link
Member

dmuelle commented Dec 4, 2023

@ramkumar-k-9286
Copy link
Contributor

ramkumar-k-9286 commented Dec 5, 2023

Peer Review

A span represents a single operation in a request and contains a name, time-related data, log messages, and metadata to gather data about what occurs during a transaction.
-> ( Acrolinx - Too Complex)
A span represents a single operation in a request. It includes a name, time-related data, log messages, and metadata to collect information about what happens in a transaction.


MicroProfile Telemetry is based on the OpenTelemetry project, which is a collection of open source vendor-independent tools, APIs, and SDKs for creating and managing trace data.
->
MicroProfile Telemetry is based on the OpenTelemetry project, a collection of open-source vendor-independent tools, APIs, and SDKs for creating and managing trace data.


For information about migrating your applications from MicroProfile OpenTracing to MicroProfile Telemetry, see Differences between MicroProfile Telemetry 1.0 and MicroProfile OpenTracing 3.0.
->
For more information about migrating your applications from MicroProfile OpenTracing to MicroProfile Telemetry, see Differences between MicroProfile Telemetry 1.0 and MicroProfile OpenTracing 3.0.


For example, to use a Jaeger server, you might add configuration similar to the following example to your bootstrap.properties file:
->
For example, to use a Jaeger server, you might add a configuration similar to the following example to your bootstrap.properties file:


Enable MicroPRofile Telemetry, as described in Configuring Open Liberty to use MicroProfile Telemetry.
->
Enable MicroProfile Telemetry, as described in Configuring Open Liberty to use MicroProfile Telemetry.


automatic instrumentation, which automatically
->
Automatic Instrumentation, which automatically

manual instrumentation, which allows you to
->
Manual Instrumentation, which allows you to

agent instrumentation, which automatically adds telemetry to
->
Agent Instrumentation, which automatically adds telemetry to


If you set any properties by using environment variables, including the in the server.env file, the keys must be in uppercase and all punctuation must be replaced by an underscore. Values must be written normally.
->
If you set any properties by using environment variables, including those in the server.env file, the keys must be in uppercase and all punctuation must be replaced by an underscore. Values must be written normally.


opentelemetry-instrumentation-annotions
->
opentelemetry-instrumentation-annotations
(This is in a code block - annotations spell check)

dmuelle added a commit that referenced this issue Dec 5, 2023
@dmuelle
Copy link
Member

dmuelle commented Dec 5, 2023

Thanks @ramkumar-k-9286, all suggestions implemented, except "a configuration", as I think "configuration" is a collective noun in this context and doesn't need an article. It wouldn't necessarily be incorrect but seems awkward.

https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/microprofile-telemetry.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.0.0.12 peer reviewed technical reviewed An SME reviewed and approved the documentation from a technical perspective.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants