-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ED: Extended yaw-friction modeling #2561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and additional Coulomb-friction terms proportional to yaw-bearing shear force and bending moment
…gion where the quadratic viscous friction should be linearized
…coefficients for the yaw bearing are greater than or equal to their dynamic counterparts
luwang00
changed the title
Extend yaw-friction modeling
ED: Extended yaw-friction modeling
Dec 16, 2024
jjonkman
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the implementation plan with Lu previously and these changes match my expectations.
@abhineet-gupta -- Could you review this one as well considering you implemented the original version in PR #2017? |
Will do. |
andrew-platt
approved these changes
Dec 16, 2024
abhineet-gupta
approved these changes
Dec 17, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR extends the existing yaw-friction modeling in ElastoDyn with
YawFrctMod=2
with additional terms. The extended list of inputs for yaw-friction modeling is listed below.When
YawFrctMod=2
, the new inputsM_FCSmax
andM_MCSmax
allow the introduction of static Coulomb friction terms proportional to the yaw-bearing shear force and bending moment, respectively. This is in addition to the term proportional to the yaw-bearing axial force controlled byM_CDmax
. The dynamic counterparts toM_FCSmax
andM_MCSmax
are also added. These are the newM_FCD
andM_MCD
inputs.For viscous friction, an additional quadratic friction coefficient
sig_v2
is introduced. Finally,OmgCut
defines a region about zero yaw rate where the quadratic viscous friction is to be linearized. SettingOmgCut=0
disables linearization.OmgCut
has no effect whensig_v2=0
.All new inputs are required to be equal to or greater than zero. Furthermore, the static Coulomb friction coefficients,
M_CSmax
,M_FCSmax
, andM_MCSmax
all need to be greater than or equal to their dynamic counterparts,M_CD
,M_FCD
, andM_MCD
, respectively. These requirements are checked and enforced in the code.The ElastoDyn input and theory documentation have been updated to reflect the extended list of inputs and the new yaw-friction formulation.
Impacted areas of the software
ElastoDyn
Test results, if applicable
No change to existing test results, but the r-test ElastoDyn input files need to be updated with the new inputs. Please see the r-test pointer from this PR.