bugfix: with OLAF, BoxExceed was allowed for all points #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in PR OpenFAST#2518. The result was that anytime the driver was used with OLAF, all points were allowed outside the box, not just the wake as intended.
IfW defaults this to -1, so if OLAF is used it would simply pass -1 for the index rather than the correct location from the AD_BoxExceedPointsIdx routine.
andrew-platt
changed the title
deslaughter
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
PR #2518 had a logic issue with how the
BoxExceedAllowIdxwas set. The InflowWind registry sets this value to-1by default, so a check ofmin(BoxExceedAllowIdx, AD_BoxExceedPointsIdx(u_AD, o_AD))would always return a-1, which would cause InflowWind to allow all calculation at all points requested that were outside the wind box, not just the OLAF points as intended (blades, tower, etc must be inside the box, but OLAF points may exit the box).This logic issue was also present in the glue code.
Related issue, if one exists
#2518
Impacted areas of the software
Extrapolation of wind values outside the wind box when OLAF is used.
Additional supporting information
It is possible that some users will find simulations that they had previously been able to run will now fail if a blade is outside the box when OLAF is used.
Test results, if applicable
None