ADI bugfix: BoxExceed was not enabled for OLAF with ADI #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither the C-bindings nor AD driver could use the BoxExceedAllow option with OLAF
deslaughter
approved these changes
Nov 15, 2024
andrew-platt
added a commit
to andrew-platt/openfast
that referenced
this pull request
Nov 22, 2024
This was introduced in PR OpenFAST#2518. The result was that anytime the driver was used with OLAF, all points were allowed outside the box, not just the wake as intended.
andrew-platt
added a commit
to andrew-platt/openfast
that referenced
this pull request
Nov 22, 2024
This was introduced in PR OpenFAST#2518. The result was that anytime the driver was used with OLAF, all points were allowed outside the box, not just the wake as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Neither the C-bindings nor AD driver could use the
BoxExceedAllowoption withOLAFRelated issue, if one exists
Reported out side of GH
Impacted areas of the software
This will allow AeroDyn driver and ADI library to handle wind with OLAF that exceeds the bounds of the turbulent wind box the same way that OpenFAST does.
Additional supporting information
This issue is also present in 4.0.0
Test results, if applicable
N/A