Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add time step, time series #538

Merged
merged 18 commits into from
Sep 23, 2020
Merged

add time step, time series #538

merged 18 commits into from
Sep 23, 2020

Conversation

akleinau
Copy link
Contributor

part of #267

  • moves quantity value class over to oeo-shared bc it's needed in oeo-model too and was in oeo-physical
  • moved lenght value with it bc I think it's also needed in more than oeo-physical

add classes with definitions:

  • start time and end time: start time is a zero-dim temporal region that indicates the beginning of a 1-dim temporal region. End time indicating the end, accordingly.
  • duration is a quantity value that can be related to both time step and time series. duration is a quantity value indicating the time span of a 1-dim temporal region, measured in a time unit.
  • time step: a time step is a 1-dim temporal region that has a start time and an endtime and thus a finite duration.
  • time series: time series is a data set that references a set of time steps or zero-dim temporal regions.

add relations:

  • duration: is about some 1-dim temporal region and has unit some time unit
  • time step: has part some start time and has part some end time and has part some duration
  • time series: has part some start time and has part some end time and has part some duration
  • time series: is about some (time step or zero-dim temporal region)

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module labels Aug 28, 2020
@akleinau akleinau changed the title Feature/timeseries #267 add time step, time series Aug 28, 2020
@akleinau akleinau added the oeo-shared changes the oeo-shared module label Aug 28, 2020
@stap-m
Copy link
Contributor

stap-m commented Aug 31, 2020

moved lenght value with it bc I think it's also needed in more than oeo-physical

@akleinau Do you have an example for length value to be used in another module?
It's a point worth a discussion. Our models depict what's located in the physical world. Thus, many classes from oeo-model will be related to classes from oeo-physical. Can relations work across modules?

For time series it definitely makes sense to be part of oeo-model.
But start time etc could also be seen as part of oeo-physical.

@akleinau
Copy link
Contributor Author

akleinau commented Sep 1, 2020

moved lenght value with it bc I think it's also needed in more than oeo-physical

@akleinau Do you have an example for length value to be used in another module?
It's a point worth a discussion. Our models depict what's located in the physical world. Thus, many classes from oeo-model will be related to classes from oeo-physical. Can relations work across modules?

For time series it definitely makes sense to be part of oeo-model.
But start time etc could also be seen as part of oeo-physical.

yes, that asks the question which relations and entities are placed in oeo-shared (imported in all modules) and which in oeo.omn (put on top of all modules). I would say to put everything thats needed in more than one module to connect classes of one module to each other in oeo-shared and everything that combines more modules in oeo.omn.

So start time and end time could be needed in both modules to build relations in these modules and therefore oeo-shared.
Length value is used for relations in oeo-physical and might be for relations between oeo-physical and oeo-model, therefore it is in oeo-physical and these relations will be in oeo.omn

@akleinau akleinau requested a review from stap-m September 1, 2020 08:31
@sfluegel05 sfluegel05 mentioned this pull request Sep 7, 2020
5 tasks
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Sep 15, 2020
@sfluegel05 sfluegel05 self-requested a review September 21, 2020 12:36
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Sep 21, 2020
@Vera-IER Vera-IER self-requested a review September 21, 2020 12:39
Class: OEO_00030033

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "a time step is a one-dimensional temporal region that has a start time and an endtime and thus a finite duration.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start the sentence with a capital letter.

Class: OEO_00030034

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "time series is a data set that references to a set of time steps or zero-dimensional temporal regions.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Class: OEO_00030035

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "duration is a quantity value indicating the time span of a one-dimensional temporal region, measured in a time unit.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Class: OEO_00030031

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "start time is a zero-dimensional temporal region that indicates the beginning of a one-dimensional temporal region.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start the sentence with a capital letter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add an "A" in the beginning, so "A start time..." (and analogous for the others).


Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "ending time is a zero-dimensional temporal region that indicates the end of a one-dimensional temporal region.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

Copy link
Contributor

@sfluegel05 sfluegel05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to resolve the merge conflicts. I wasn't sure about some things:

But I think it is working now.

@akleinau akleinau merged commit 1433be0 into dev Sep 23, 2020
@akleinau akleinau deleted the feature/timeseries-#267 branch September 23, 2020 11:12
@Ludee Ludee linked an issue Oct 14, 2020 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timestep, timehorizon, timeseries need new place and def
4 participants