-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add time step, time series #538
Conversation
@akleinau Do you have an example for For |
yes, that asks the question which relations and entities are placed in oeo-shared (imported in all modules) and which in oeo.omn (put on top of all modules). I would say to put everything thats needed in more than one module to connect classes of one module to each other in oeo-shared and everything that combines more modules in oeo.omn. So start time and end time could be needed in both modules to build relations in these modules and therefore oeo-shared. |
src/ontology/edits/oeo-model.omn
Outdated
Class: OEO_00030033 | ||
|
||
Annotations: | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "a time step is a one-dimensional temporal region that has a start time and an endtime and thus a finite duration.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please start the sentence with a capital letter.
src/ontology/edits/oeo-model.omn
Outdated
Class: OEO_00030034 | ||
|
||
Annotations: | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "time series is a data set that references to a set of time steps or zero-dimensional temporal regions.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
src/ontology/edits/oeo-model.omn
Outdated
Class: OEO_00030035 | ||
|
||
Annotations: | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "duration is a quantity value indicating the time span of a one-dimensional temporal region, measured in a time unit.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
src/ontology/edits/oeo-shared.omn
Outdated
Class: OEO_00030031 | ||
|
||
Annotations: | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "start time is a zero-dimensional temporal region that indicates the beginning of a one-dimensional temporal region.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please start the sentence with a capital letter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add an "A" in the beginning, so "A start time..." (and analogous for the others).
src/ontology/edits/oeo-shared.omn
Outdated
|
||
Annotations: | ||
<http://purl.obolibrary.org/obo/IAO_0000115> "ending time is a zero-dimensional temporal region that indicates the end of a one-dimensional temporal region.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to resolve the merge conflicts. I wasn't sure about some things:
- in commit e902808 the
unique individual identifier
from Add annotation property unique individual identifier and some IPCC sector indiviuals #523 got removed (I re-added it) - in 7c26aa6 you added
quantity value
to oeo-shared without removing it from oeo-physical (those two were also different versions ofquantity value
, in oeo-physical it was the version after Add is about property #518, in oeo-shared it was the version before Add is about property #518 ) (I removed it from oeo-physical and updated it in oeo-shared) - oeo-physical doesn't import the uo-module anymore and oeo-shared doesn't import the iao-minimal-module anymore. I don't know if this will lead to problems or not.
But I think it is working now.
part of #267
add classes with definitions:
add relations:
is about some 1-dim temporal region
andhas unit some time unit
has part some start time
andhas part some end time
andhas part some duration
has part some start time
andhas part some end time
andhas part some duration
is about some (time step or zero-dim temporal region)