Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation property unique individual identifier and some IPCC sector indiviuals #523

Merged
merged 12 commits into from
Aug 24, 2020

Conversation

l-emele
Copy link
Contributor

@l-emele l-emele commented Aug 19, 2020

This issue partially solves #461:

  • Add annotation property 'unique individual identifier': A unique individual identifier is an alternative term that is unique for one individual of a class. Unique individual identifiers follow usually a structure defined e.g. by a sector division.
  • Add some IPCC sector individuals as start for populating sector individuals. (Further individuals will be implemented later.)

@github-actions github-actions bot added the oeo-social changes the oeo-social module label Aug 19, 2020
@l-emele l-emele marked this pull request as ready for review August 20, 2020 09:55
@l-emele l-emele requested review from jannahastings, stap-m, Vera-IER and akleinau and removed request for jannahastings August 20, 2020 09:55
@Vera-IER
Copy link
Contributor

I see that the unique individual identifier is defined in OEO social. Could it still be used for classes in the OEO physical?

@l-emele
Copy link
Contributor Author

l-emele commented Aug 20, 2020

I see that the unique individual identifier is defined in OEO social. Could it still be used for classes in the OEO physical?

So shall we move it to oeo-shared?

@Vera-IER
Copy link
Contributor

Yes, I think this identifier could also be helpful for physical classes.

@l-emele
Copy link
Contributor Author

l-emele commented Aug 20, 2020

@akleinau : Could you please give me some advice how to move the unique individual identifier from oeo-social to oeo-shared without braking anything?

@akleinau
Copy link
Contributor

it should work when you open a text editor and copy the code lines for the annotation over

@stap-m
Copy link
Contributor

stap-m commented Aug 20, 2020

Please also update the changelog file

@l-emele l-emele mentioned this pull request Aug 21, 2020
1 task
@l-emele
Copy link
Contributor Author

l-emele commented Aug 21, 2020

I've added the definitions and updated CHANGELOG.md.

@l-emele l-emele requested a review from akleinau August 21, 2020 10:16
@l-emele l-emele merged commit 6df5a85 into dev Aug 24, 2020
@l-emele
Copy link
Contributor Author

l-emele commented Aug 24, 2020

I've merged but I've intentionally not deleted the branch feature/sector-division-461 as this PR only partially resolved issue #461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-social changes the oeo-social module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants