Extend vehicle subclasses

[l-emele]

closes #425

Adds the following vehicles classes:

• battery electric vehicle
• fuel cell electric vehicle
• grid supplied electric vehicle
• plug-in hybrid electric vehicle

Adds the following energy converting devices and energy storage objects:

• traction battery
• motor
• electric motor
• traction motor
• internal combustion engine

[l-emele]

There are some merge conflicts, probably from #450. @akleinau : Can you please help with resolving these merge conflicts?

[akleinau]

yes I'll fix, this is a bit weird

[l-emele]

Thanks a lot.

[akleinau]

ok @l-emele following problem at your side: when you commit sth, I guess your protege, changes the standard prefix of oeo-physical to another one which basically changes all class names in the file. Which creates merge conflicts.

[akleinau]

see commit "add missing word in vehicle definition".
I changed it back and solved the conflicts though

[l-emele]

Oh, that is not good. I've checked my protege preferences: They are as described in https://github.com/OpenEnergyPlatform/ontology/wiki/Numerical-Identifiers . Any other preferences apart from the "new entries" that I may have set wrong?

[akleinau]

Oh, that is not good. I've checked my protege preferences: They are as described in https://github.com/OpenEnergyPlatform/ontology/wiki/Numerical-Identifiers . Any other preferences apart from the "new entries" that I may have set wrong?

actually I have no idea, @jannahastings?

[jannahastings]

Typically this would be the New entities preferences, Entity IRI -> Start with -> Specified IRI (not 'active ontology IRI). If you think your settings should be correct, could you add a screenshot here?

[l-emele]

[l-emele]

Apart from my protege problems (and which @akleinau already fixed):

Are there any things to change here? As this PR adds a lot of classes I think it would be nice if can finalise the review and merge the PR before the OEO meeting tomorrow afternoon.

[jannahastings]

my protege problems

Indeed your settings look correct :-(... I'm not really sure what else it might be. Let's monitor closely next time you are creating new classes, but I agree this PR is good to go

[stap-m]

I am not done with the review but I just saw that there are many annotations with @de. I can fix it in the review but maybe you can also take a look at your settings here.

[l-emele]

I am not done with the review but I just saw that there are many annotations with @de. I can fix it in the review but maybe you can also take a look at your settings here.

Thanks, I fixed my settings for that.