Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shared module and make energy transformation subclass of transformation #450

Merged
merged 6 commits into from
Jun 24, 2020

Conversation

akleinau
Copy link
Contributor

closes #435

  • adds shared module "oeo-shared" which will provide all classes needed in all other edit modules, as well as imports like bfo, iao-annotation and ro.
  • rewrites the imports of the other modules accordingly.
  • moves "Transformation" into this module
  • makes "energy transformation" subclass of "transformation"

Maybe the description of the new module can be refined?

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-social changes the oeo-social module labels Jun 22, 2020
@akleinau akleinau changed the title Feature/shared module #435 add shared module and make energy transformation subclass of transformation Jun 22, 2020
@akleinau
Copy link
Contributor Author

@jannahastings @MGlauer unfortunately the transformation class in the new module has a "http://openenergy-platform.org/ontology/oeo" identifier and therefore travis thinks it has no label when it's imported into oeo-physical (bc the label is in oeo-shared).
Which means our ontology runs perfectly right now but the tests fail.

@jannahastings
Copy link
Contributor

@MGlauer Is it possible for the tests to run robot merge to combine the different OEO modules, before checking the labels?

@jannahastings
Copy link
Contributor

This is great. Also in the future we can move some of our object properties into the shared module (e.g. "uses" I think is used in different modules) -- but that should be part of a separate issue and later PR.

@akleinau akleinau merged commit 07d3d0e into dev Jun 24, 2020
@akleinau akleinau deleted the feature/sharedModule-#435 branch June 24, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-social changes the oeo-social module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "energy transformation" subclass of "transformation"
4 participants