Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modelfactsheets #109

Merged
merged 6 commits into from
Dec 19, 2019
Merged

Feature/modelfactsheets #109

merged 6 commits into from
Dec 19, 2019

Conversation

Bachibouzouk
Copy link
Contributor

No description provided.

@MGlauer MGlauer self-assigned this Dec 3, 2019
@akleinau
Copy link
Contributor

akleinau commented Dec 16, 2019

this pull request adds some objectproperties to oeo. Apart from that it just changes many orders of annotations in oeo. It should be merged or deleted before #167

It also adds a model.ttl file

@akleinau akleinau assigned akleinau and unassigned MGlauer Dec 19, 2019
@akleinau akleinau marked this pull request as ready for review December 19, 2019 08:53
@akleinau
Copy link
Contributor

akleinau commented Dec 19, 2019

ok, so this is old work with no issue. It adds entities that are really useful for #15, representing model factsheets with this ontology.
Because it's old and issue-less and just adds properties (and a file) I propose to merge fast (also so we can start modularisation) and delete properties (or the file) later if they are too useless.

Edit: changed #192 to #15

oeo.omn Outdated
ObjectProperty: covers_energy_sector

SubPropertyOf:
covers_sector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should delete "covers_energy_sector" and "covers_demand_sector" though because the sector discussion isn't decided yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@akleinau akleinau requested review from akleinau and removed request for akleinau December 19, 2019 10:27
@akleinau akleinau merged commit 4d53029 into dev Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants