Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better alignment with ENVO #636

Open
1 task done
jannahastings opened this issue Dec 30, 2020 · 11 comments · Fixed by #810
Open
1 task done

Better alignment with ENVO #636

jannahastings opened this issue Dec 30, 2020 · 11 comments · Fixed by #810
Assignees
Labels
external ontology external ontologies that could be included oeo dev meeting Discuss issue at oeo dev meeting

Comments

@jannahastings
Copy link
Contributor

jannahastings commented Dec 30, 2020

Description of the issue

We need to align the OEO better with ENVO. See EnvironmentOntology/envo#1053

Ideas of solution

We should compare their definitions with ours for overlapping terms and note similarities and divergences. At the minimum we need to include cross-references.

Workflow checklist

  • I am aware of the workflow for this repository
@jannahastings jannahastings added the To do Issues that haven't got discussed yet label Dec 30, 2020
@l-emele l-emele added the external ontology external ontologies that could be included label Jan 7, 2021
@akleinau akleinau self-assigned this Jan 8, 2021
@akleinau
Copy link
Contributor

akleinau commented Jan 8, 2021

I'll make a sheet

@akleinau
Copy link
Contributor

akleinau commented Jan 8, 2021

https://docs.google.com/spreadsheets/d/1EJ_c_t1WQhi_hLvAe8RIhUqZ0tdhKpKfce53fwXX44A/edit?usp=sharing
this is a sheet with all maybe related and equivalent terms I could find

@stap-m
Copy link
Contributor

stap-m commented Mar 5, 2021

Is this a good issue for a dev meeting?

@stap-m stap-m added this to the oeo-release-1.5.0 milestone Mar 5, 2021
@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Mar 5, 2021
@jannahastings
Copy link
Contributor Author

yes, I think so. I could lead the discussion on this point in the dev meeting.

@stap-m stap-m added the oeo dev meeting Discuss issue at oeo dev meeting label Mar 8, 2021
@l-emele
Copy link
Contributor

l-emele commented Apr 27, 2021

For documentation: In the OEO Developer Meeting 15 we decided:

  • main outcomes: keep our own definition and make connection to ENVO clear (sameAs-relation)
  • todo's:
    • revisit and refine i.a. coal, (solar energy), oil and petroleum products definition
    • JH creates mapping until next time

Next discussion on this topic postponed from to OEO Dev Meeting 17.

@sfluegel05
Copy link
Contributor

I added some classes and comments to the mapping. Also, I marked the pairs of classes which are not the same in yellow.

@sfluegel05 sfluegel05 mentioned this issue Jun 1, 2021
5 tasks
@sfluegel05
Copy link
Contributor

sfluegel05 commented Jun 17, 2021

In dev meeting 19 we discussed the following options for annotation properties:

  1. rdfs:seeAlso
  2. owl:equivalentClass in extra module (oeo-envo-mapping) that imports ENVO and OEO
  3. owl:equivalentClass with literals linking to ENVO classes instead of IRIs (no automatic reasoning possible, but doesn't interfere with our class structure)

We chose the third option, because it doesn't require a new module, but is still provides all the necessary information (i.e. the link to ENVO). It is also extensible (e.g. to the second option) if this is later needed.
An example of the third option has been implemented in PR #765

@sfluegel05
Copy link
Contributor

In dev meeting 22, we discussed the remaining unclear cases. We decided to open two new issues for oil and petroleum products and pollution and implement the rest.
For documentation purporses, here is a PDF version of our collaborative sheet: envo-oeo-relations-table-21-07-29.pdf

@cmungall
Copy link

Hi @jannahastings et al, just catching up on this. Great to see action on this!

For those ending up at this issue:

  • it looks like the (unusual) decision to pun owl:equivalentClass as an annotation property was revoked and the (imprecise and non-standard) IAO:0006011 is now used
  • both this issue and the reciprocal issue on the ENVO were closed but the mappings are not particularly transparent

I would like to reopen this and propose

  • skos predicates are used following SSSOM conventions
  • the mappings are surfaced more on both the ENVO and OEO side
  • we have some loose coordinating to avoid duplicating work

Maybe some kind of zoom call between ENVO and OEO developers would be useful?

@cmungall
Copy link

It also looks like the mappings provided in OEO are quite incomplete

e.g of

  • [] OEO:00000331 ! portion of matter
    • [i] OEO:00000441 ! water
      • [i] OEO:00110001 ! steam
      • [i] OEO:00110000 ! liquid water
        • [i] OEO:00010104 ! water body
          • [i] OEO:00010105 ! ocean
          • [i] OEO:00010093 ! river
        • [i] OEO:00000345 ! pumped water

and

  • [] ENVO:01001476 ! body of liquid
    • [i] ENVO:01000685 ! water mass
      • [i] ENVO:00000063 ! water body
        • [i] ENVO:01000617 ! lentic water body
          • [i] ENVO:00001999 ! marine water body
            • [i] ENVO:00000015 ! ocean
        • [i] ENVO:01001319 ! saline water body
          • [i] ENVO:00000015 ! ocean
        • [i] ENVO:01000618 ! lotic water body
          • [i] ENVO:00000029 ! watercourse
            • [i] ENVO:00000023 ! stream
              • [i] ENVO:00000022 ! river

only "river" is mapped

Also, OEO maps from http://openenergy-platform.org/ontology/oeo/OEO_00000441 water to CHEBI "water". However, all OEO terms like water, methane etc actually have better mappings in ENVO under material, e.g.

image

@stap-m stap-m reopened this Apr 30, 2024
@stap-m
Copy link
Contributor

stap-m commented May 22, 2024

  • it looks like the (unusual) decision to pun owl:equivalentClass as an annotation property was revoked and the (imprecise and non-standard) IAO:0006011 is now used

Discussion in oeo-dev-79:

  • discuss an alternative for IAO:0006011 in OEO:
    • skos:relatedMatch
    • skos:close match
    • skos:exactMatch
  • become SSSOM conform: https://mapping-commons.github.io/sssom/about/
  • decision: for now replace may be identical to/ IAO:0006011 with skos:closeMatch, import skos:relationMappings hierarchy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external ontology external ontologies that could be included oeo dev meeting Discuss issue at oeo dev meeting
Projects
Status: In discussion
Development

Successfully merging a pull request may close this issue.

6 participants