-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed obsoletion: IAO:0006011 'may be identical to' #173
Comments
Maybe I missed something, but migrate to what? I am not sure that would be appropriate. In FBbt we use that annotation to indicate that two terms may refer to the same thing, but maybe not at all – we are not sure.
Using an annotation representing a “proposed KGCL merge operation” would also seem inappropriate, for the same reason: it conveys a degree of confidence that we do not have in the cases where we use IAO:0006011. So I would personally vote to keep. No objection on renaming it and documenting it better. Not sure about making it a sub property of |
Then again, if we do use, instead of an annotation, a intra-ontology SSSOM mapping set, then we could use But then we’d need to make sure that our tools (typically the VFB interface, since most of the cases where IAO:0006011 is used are for neurons) can exploit those mappings and display them appropriately. |
Just an update from the Slack discussion thread for this:
|
@joeflack4 I am not arguing against using SSSOM for intra-ontology mappings. I have no objection against that (I see no reason why we could not use SSSOM for intra-ontology mappings). My concern is about the predicate to use. |
Oh, sorry. Chris asked me to add our comments to the issue; but I didn't even look at what the issue was about. I haven't given thought to that yet (I don't think Nico has either). Will take a look tomorrow. |
Looping in @stap-m for the OEO, as I am not so much involved in OEO at the moment. |
After finally reading this, I mostly agree with @gouttegd. I lean towards keeping If it is kept, then, along with @gouttegd, I disagree with the suggestion of " If it is obsoleted, then I like @gouttegd's suggestion of using Sidebar on "intra ontology": |
Another quick fix to the documentation issue would be to add some instructions to the terms description to not use it to refer to a term from another ontology. Either way, I think we dont need to be so prescriptive here as to remove it entirely - it is enough to clarify what its intended use is, and imo its intended use is to say: "in the future these terms could be merged". So basically this is like a "consider replacement" before the term has been obsoleted. |
I'm glad this thread reminded me of this AP. I think it will be v.useful in upcoming work on CL. We have an increasing number of cases where we have some evidence that two CL terms identified via different modalities may refer to the same cell type, but there is enough uncertainty/controversy that we don't want to merge, at least until we have more evidence. It is useful for editors and users to be able to track these. |
Thanks for considering the usage in OEO. Based on this discussion, OEO is planning to replace IAO:0006011 with skos:closeMatch. |
http://purl.obolibrary.org/obo/IAO_0006011
A annotation relationship between two terms in an ontology that may refer to the same (natural) type but where more evidence is required before terms are merged
Looking at this, and also at the original ticket
It looks like this is for a very specific use case of mapping between terms in the same ontology (i.e candidate merge). This is how it has been used in OBO so far (the only user is FBbt, cc @dosumis @gouttegd). IMO an OMO AP used in only one ontology is an antipattern. We want to encourage unification
However, it looks like OEO have been using this as a mapping predicate between ontologies
cc @jannahastings
I propose one of the following:
Keep
may be identical to term in same ontology
orhas candidate merge term
)IAO:0006011 skos:closeMatch skos:closeMatch
Obsolete
The term was added in 2018, pre SSSOM. Arguably the original use case has nothing to do with "mapping" per se (but see comments above), and should never appear in a SSSOM file. However, I feel this is really just a FBbt convention of using closeMatch inter-ontology
If we did obsolete we would give both FBbt and OEO as long as they needed to migrate.
Another way to handle this as a candidate merge (discussed with Damien here: INCATools/kgcl#49)
The text was updated successfully, but these errors were encountered: