Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitivity analysis should be included in the ontology #483

Closed
5 tasks
akleinau opened this issue Jul 9, 2020 · 19 comments · Fixed by #550
Closed
5 tasks

Sensitivity analysis should be included in the ontology #483

akleinau opened this issue Jul 9, 2020 · 19 comments · Fixed by #550
Assignees
Labels
[A] new term Including new term(s) in the ontology oeo-model changes the oeo-model module ready for implementation

Comments

@akleinau
Copy link
Contributor

akleinau commented Jul 9, 2020

Description of the issue

Sensivities (in the context of sensitivity analysis) should be included in the ontology as they are used in the excel scenario factsheets.

Ideas of solution

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@akleinau akleinau added the [A] new term Including new term(s) in the ontology label Jul 9, 2020
@l-emele l-emele added this to the oeo-release-1.1 milestone Jul 10, 2020
@l-emele l-emele added the oeo-model changes the oeo-model module label Jul 10, 2020
@han-f han-f changed the title Sensivity should be included in the ontology Sensitivity should be included in the ontology Jul 24, 2020
@han-f
Copy link
Contributor

han-f commented Jul 24, 2020

I wonder whether we should name the term "sensitivity analysis" instead. I think "sensitivity" is more colloquial (and is also used in other contexts).

My line of thinking:
when someone says: "I ran a sensitivity" , he/she probably implies that he/she modified parameters of a model according to a certain method, ran the model again and created outputs based on the changed parameters. This whole exercise is done to compare the outputs based on the sensitivity settings with the "original" outputs based on the original settings.

The factsheet for PszVIII(scenarios) states for example under "Sensitivities": Analysis for higher population development, economic development, lower energy prices in comparison with lower CO2-price path. -> So maybe the term in the factsheet was a bit fuzzy to start with?
What do the others think?
@stap-m @jannahastings @l-emele @christian-rli @Ludee

@jannahastings
Copy link
Contributor

I wonder whether we should name the term "sensitivity analysis" instead.

This sounds good to me.

@christian-rli
Copy link
Contributor

As someone from not in the field I would not have known what was meant by just "sensitivity". "sensitivity analysis" is more self explanatory and also doesn't seem redundant to me. So it sounds good to me as well.

@akleinau
Copy link
Contributor Author

akleinau commented Aug 4, 2020

sounds like sensitivity analysis is best described as a process? The process of recording outputs of a model based on different sets of parameters that are chosen according to different methods?

@han-f
Copy link
Contributor

han-f commented Aug 5, 2020

sounds like sensitivity analysis is best described as a process? The process of recording outputs of a model based on different sets of parameters that are chosen according to different methods?

I could go with that.

@stap-m
Copy link
Contributor

stap-m commented Aug 5, 2020

Process sounds good to me. Create a parent class analysis for sensitivity analysis? I am not sure if this is necessary/helpful, though.

An analysis is more that recording outputs.
The process of comparing different model calculations based on a variation of input parameters (exogenous data items)?
Also include: has part some model calculation?

@akleinau
Copy link
Contributor Author

akleinau commented Aug 5, 2020

I think it would be enough to include an analysis class when we need a second analysis subclass.

Is your def a def for sensitivity analysis or for analysis?

@stap-m
Copy link
Contributor

stap-m commented Aug 5, 2020

Ok. It's for sensitivity analysis.

@akleinau
Copy link
Contributor Author

akleinau commented Aug 5, 2020

input parameters is more intuitive for me, so go with that instead of exogeneous data items?

@christian-rli
Copy link
Contributor

christian-rli commented Aug 5, 2020

input parameters is more intuitive for me, so go with that instead of exogeneous data items?

I feel the same way. Was there a particular reason for naming it exogeneous data items in the first place? It seems very specific.

@akleinau
Copy link
Contributor Author

akleinau commented Aug 5, 2020

we just included that class as well as endogeneous data item in #482 as part of including the classes needed for the oeo factsheets

@stap-m
Copy link
Contributor

stap-m commented Aug 5, 2020

Yes, it's exogenous data btw, sorry. Since we already have the class, I'd like to refer to it in brakets.

@akleinau
Copy link
Contributor Author

akleinau commented Aug 5, 2020

I would still leave it out because with the brackets it looks like it‘s just another term for input data and in my understanding those two concepts are not the same?

@stap-m
Copy link
Contributor

stap-m commented Aug 5, 2020

We don't have input data included yet... How would you define it?
Exogeneous data is a data item whose quantity value is determined outside of a model and is imposed on a model.

@akleinau
Copy link
Contributor Author

akleinau commented Aug 5, 2020

do we need that class and should create a new issue for input data?

@l-emele l-emele changed the title Sensitivity should be included in the ontology Sensitivity analysis should be included in the ontology Aug 19, 2020
@l-emele l-emele self-assigned this Aug 19, 2020
@sfluegel05
Copy link
Contributor

#520 came to the conclusion that input data is the same as exogenous data. So we can use the definition for sensitivity analysis @stap-m suggested:

The process of comparing different model calculations based on a variation of input parameters (exogenous data items)?

@han-f
Copy link
Contributor

han-f commented Aug 28, 2020

#520 came to the conclusion that input data is the same as exogenous data. So we can use the definition for sensitivity analysis @stap-m suggested:

The process of comparing different model calculations based on a variation of input parameters (exogenous data items)?

Reads good to me.

@l-emele
Copy link
Contributor

l-emele commented Aug 31, 2020

I agree, too.

@l-emele
Copy link
Contributor

l-emele commented Sep 2, 2020

I'll implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[A] new term Including new term(s) in the ontology oeo-model changes the oeo-model module ready for implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants