Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topics Page] Implement reworked UI #1201

Closed
1 of 5 tasks
jh-RLI opened this issue Apr 11, 2023 · 4 comments · Fixed by #1203
Closed
1 of 5 tasks

[Topics Page] Implement reworked UI #1201

jh-RLI opened this issue Apr 11, 2023 · 4 comments · Fixed by #1203
Assignees
Labels
is_active the issue is still active and needs to be resolved

Comments

@jh-RLI
Copy link
Contributor

jh-RLI commented Apr 11, 2023

We created a prototype of the OEP-Topics page (forma schma page).

@bmlancien
Copy link
Contributor

Design to implement:

db__topics--cards-simple

@u-mueller
Copy link

I like the design! One small remark: the model-draft bar is quite eye catching for the topics page, wouldn't it be better that way in the review section?

@jh-RLI: How do you link the tables to the topics? Shall this also be discussed in connection with our scenario factsheets?

@jh-RLI
Copy link
Contributor Author

jh-RLI commented Apr 12, 2023

Good feedback :)

model_draft is bigger because we want to make it more understandable that the user can only upload data on this topic. It is also to show that the data is not officially published. But maybe you are right and it is a bit too catchy. The reviews section is not fully fleshed out yet. In the future there will be a list of ongoing and completed reviews on the profile page and a review can be started when looking at a single table.

Currently, the new user role of reviewer is being introduced to assign reviews to a profile, but it is not yet clear where the complete list of all open reviews will be displayed. In this sense, a separate review section that looks like this topics page is not yet planned.

@u-mueller It would be good to have a discussion about this, as I am not quite sure what this question is aimed at :) I am not up to date with the latest development of the factsheets. But I think we need to plan the development carefully to avoid duplicate or misleading functions. Perhaps your question is aimed at the Bundles that also need to be developed?

@u-mueller
Copy link

Thanks, @jh-RLI, maybe it's a bit far fetched, I am referring to discussions about keywords in our scenario factsheets, that indeed aim at the representation of bundles in the KG. But let's talk about this in our project meeting.

bmlancien added a commit that referenced this issue Apr 13, 2023
bmlancien added a commit that referenced this issue Apr 13, 2023
@jh-RLI jh-RLI added the is_active the issue is still active and needs to be resolved label Apr 13, 2023
bmlancien added a commit that referenced this issue Apr 17, 2023
bmlancien added a commit that referenced this issue Apr 17, 2023
bmlancien added a commit that referenced this issue Apr 17, 2023
bmlancien added a commit that referenced this issue Apr 17, 2023
bmlancien added a commit that referenced this issue Apr 17, 2023
bmlancien added a commit that referenced this issue Apr 18, 2023
bmlancien added a commit that referenced this issue Apr 18, 2023
bmlancien added a commit that referenced this issue Apr 18, 2023
bmlancien added a commit that referenced this issue Apr 18, 2023
bmlancien added a commit that referenced this issue Apr 18, 2023
jh-RLI added a commit that referenced this issue Apr 19, 2023
- change base template to filter.html
- reuse html cards for topics using django template syntax and loops
- connect functionality to placeholder html #1201
jh-RLI added a commit that referenced this issue Apr 19, 2023
- change base template
- restructure filter bar content and add new filter bar layout
- connect functionality to html placeholder and add content that is still out of place #1201
bmlancien added a commit that referenced this issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is_active the issue is still active and needs to be resolved
Projects
Development

Successfully merging a pull request may close this issue.

3 participants