Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add isort linter #4114

Merged
merged 7 commits into from
Feb 5, 2023
Merged

Feature/add isort linter #4114

merged 7 commits into from
Feb 5, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Feb 2, 2023

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat L Large T-Shirt size Feature label Feb 2, 2023
@reviewpad
Copy link

reviewpad bot commented Feb 2, 2023

Reviewpad Report

Fatal

  • This PR is very large and hard to review. Please split PR into multiple

@colin99d colin99d merged commit ee34a1f into develop Feb 5, 2023
@colin99d colin99d deleted the feature/add-isort-linter branch February 5, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaslek jmaslek jmaslek approved these changes

Assignees
No one assigned
Labels
feat L Large T-Shirt size Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin99d @jmaslek