Feature/add isort linter (#4114)

* Fixed isort

* Fixed issues

* FIxed linters

---------

Co-authored-by: James Maslek <[email protected]>

custom_pre_commit/check_reserved_args.py

@@ -1,9 +1,9 @@
 """Check reserved command arguments in Controllers"""
-import os
-import sys
 import glob
+import os
 import re
-from typing import Optional, Any
+import sys
+from typing import Any, Optional
 
 RESERVED_ARGS = {
     "f": "file",

jupyterlab/documentation/setup.py

@@ -63,7 +63,7 @@
 )
 
 try:
-    from jupyter_packaging import wrap_installers, npm_builder, get_data_files
+    from jupyter_packaging import get_data_files, npm_builder, wrap_installers
 
     post_develop = npm_builder(
         build_cmd="install:extension", source_dir="src", build_dir=lab_path

jupyterlab/openbb-settings/setup.py

@@ -63,7 +63,7 @@
 )
 
 try:
-    from jupyter_packaging import wrap_installers, npm_builder, get_data_files
+    from jupyter_packaging import get_data_files, npm_builder, wrap_installers
 
     post_develop = npm_builder(
         build_cmd="install:extension", source_dir="src", build_dir=lab_path

jupyterlab/openbb/setup.py

@@ -61,7 +61,7 @@
 )
 
 try:
-    from jupyter_packaging import wrap_installers, npm_builder, get_data_files
+    from jupyter_packaging import get_data_files, npm_builder, wrap_installers
 
     post_develop = npm_builder(
         build_cmd="install:extension", source_dir="src", build_dir=lab_path

openbb_terminal/alternative/alt_controller.py

@@ -5,17 +5,16 @@
 import logging
 from typing import List
 
-from openbb_terminal.custom_prompt_toolkit import NestedCompleter
-
 from openbb_terminal import feature_flags as obbff
+from openbb_terminal.alternative import hackernews_view
+from openbb_terminal.custom_prompt_toolkit import NestedCompleter
 from openbb_terminal.decorators import log_start_end
 from openbb_terminal.helper_funcs import (
     EXPORT_ONLY_RAW_DATA_ALLOWED,
 )
 from openbb_terminal.menu import session
 from openbb_terminal.parent_classes import BaseController
-from openbb_terminal.rich_config import console, MenuText
-from openbb_terminal.alternative import hackernews_view
+from openbb_terminal.rich_config import MenuText, console
 
 logger = logging.getLogger(__name__)
 # pylint:disable=import-outside-toplevel

openbb_terminal/alternative/covid/covid_controller.py

@@ -7,10 +7,10 @@
 from typing import List
 
 import pandas as pd
-from openbb_terminal.custom_prompt_toolkit import NestedCompleter
 
 from openbb_terminal import feature_flags as obbff
 from openbb_terminal.alternative.covid import covid_view
+from openbb_terminal.custom_prompt_toolkit import NestedCompleter
 from openbb_terminal.decorators import log_start_end
 from openbb_terminal.helper_funcs import (
     EXPORT_BOTH_RAW_DATA_AND_FIGURES,
@@ -19,7 +19,7 @@
 )
 from openbb_terminal.menu import session
 from openbb_terminal.parent_classes import BaseController
-from openbb_terminal.rich_config import console, MenuText
+from openbb_terminal.rich_config import MenuText, console
 
 logger = logging.getLogger(__name__)
 

openbb_terminal/alternative/covid/covid_view.py

@@ -3,24 +3,23 @@
 
 import logging
 import os
-from typing import Optional, List
+from typing import List, Optional
 
 import matplotlib.pyplot as plt
 import pandas as pd
 
-from openbb_terminal.config_terminal import theme
 from openbb_terminal.alternative.covid import covid_model
 from openbb_terminal.config_plot import PLOT_DPI
+from openbb_terminal.config_terminal import theme
 from openbb_terminal.decorators import log_start_end
 from openbb_terminal.helper_funcs import (
     export_data,
+    is_valid_axes_count,
     plot_autoscale,
     print_rich_table,
-    is_valid_axes_count,
 )
 from openbb_terminal.rich_config import console
 
-
 logger = logging.getLogger(__name__)
 
 

openbb_terminal/alternative/hackernews_model.py

@@ -3,9 +3,11 @@
 
 
 import logging
+
 import pandas as pd
-from openbb_terminal.helper_funcs import request
+
 from openbb_terminal.decorators import log_start_end
+from openbb_terminal.helper_funcs import request
 
 logger = logging.getLogger(__name__)
 

openbb_terminal/alternative/oss/github_model.py

@@ -3,15 +3,16 @@
 # pylint: disable=C0201,W1401
 
 import logging
-from typing import Any, Dict, Optional
 import math
 from datetime import datetime
+from typing import Any, Dict, Optional
+
 import pandas as pd
 
 from openbb_terminal import config_terminal as cfg
 from openbb_terminal.decorators import check_api_key, log_start_end
-from openbb_terminal.rich_config import console
 from openbb_terminal.helper_funcs import get_user_agent, request
+from openbb_terminal.rich_config import console
 
 logger = logging.getLogger(__name__)
 

openbb_terminal/alternative/oss/github_view.py

@@ -3,22 +3,23 @@
 
 import logging
 import os
-from typing import Optional, List
+from typing import List, Optional
 
 from matplotlib import pyplot as plt
 from matplotlib import ticker
-from openbb_terminal.config_terminal import theme
+
+from openbb_terminal.alternative.oss import github_model
 from openbb_terminal.config_plot import PLOT_DPI
+from openbb_terminal.config_terminal import theme
+from openbb_terminal.cryptocurrency.dataframe_helpers import (
+    lambda_long_number_format_with_type_check,
+)
 from openbb_terminal.decorators import log_start_end
 from openbb_terminal.helper_funcs import (
     export_data,
+    is_valid_axes_count,
     plot_autoscale,
     print_rich_table,
-    is_valid_axes_count,
-)
-from openbb_terminal.alternative.oss import github_model
-from openbb_terminal.cryptocurrency.dataframe_helpers import (
-    lambda_long_number_format_with_type_check,
 )
 
 logger = logging.getLogger(__name__)

openbb_terminal/alternative/oss/oss_controller.py

@@ -5,21 +5,19 @@
 import logging
 from typing import List
 
-from openbb_terminal.custom_prompt_toolkit import NestedCompleter
-
 from openbb_terminal import feature_flags as obbff
-from openbb_terminal.alternative.oss import github_view
-from openbb_terminal.alternative.oss import runa_view, runa_model
+from openbb_terminal.alternative.oss import github_view, runa_model, runa_view
+from openbb_terminal.custom_prompt_toolkit import NestedCompleter
 from openbb_terminal.decorators import log_start_end
 from openbb_terminal.helper_funcs import (
     EXPORT_BOTH_RAW_DATA_AND_FIGURES,
     EXPORT_ONLY_RAW_DATA_ALLOWED,
-    valid_repo,
     parse_and_split_input,
+    valid_repo,
 )
 from openbb_terminal.menu import session
 from openbb_terminal.parent_classes import BaseController
-from openbb_terminal.rich_config import console, MenuText
+from openbb_terminal.rich_config import MenuText, console
 
 logger = logging.getLogger(__name__)
 

openbb_terminal/alternative/oss/runa_view.py

@@ -1,21 +1,22 @@
 """Rekt view"""
 import logging
 import os
-from typing import Optional, List
+from typing import List, Optional
 
 from matplotlib import pyplot as plt
 from matplotlib import ticker
+
 from openbb_terminal.alternative.oss import runa_model
+from openbb_terminal.config_plot import PLOT_DPI
+from openbb_terminal.config_terminal import theme
 from openbb_terminal.decorators import log_start_end
 from openbb_terminal.helper_funcs import (
     export_data,
-    plot_autoscale,
+    is_valid_axes_count,
     lambda_long_number_format,
+    plot_autoscale,
     print_rich_table,
-    is_valid_axes_count,
 )
-from openbb_terminal.config_terminal import theme
-from openbb_terminal.config_plot import PLOT_DPI
 from openbb_terminal.rich_config import console
 
 logger = logging.getLogger(__name__)

openbb_terminal/alternative/realestate/landRegistry_model.py

@@ -1,8 +1,9 @@
 """  UK Land Registry Model """
 __docformat__ = "numpy"
 
-import logging
 import io
+import logging
+
 import pandas as pd
 from SPARQLWrapper.Wrapper import CSV, SPARQLWrapper
 

openbb_terminal/alternative/realestate/landRegistry_view.py

@@ -4,9 +4,9 @@
 import logging
 import os
 
-from openbb_terminal.decorators import log_start_end
 from openbb_terminal.alternative.realestate import landRegistry_model
-from openbb_terminal.helper_funcs import print_rich_table, export_data
+from openbb_terminal.decorators import log_start_end
+from openbb_terminal.helper_funcs import export_data, print_rich_table
 from openbb_terminal.rich_config import console
 
 logger = logging.getLogger(__name__)

openbb_terminal/alternative/realestate/realestate_controller.py

@@ -6,18 +6,17 @@
 from datetime import datetime, timedelta
 from typing import List
 
-from openbb_terminal.custom_prompt_toolkit import NestedCompleter
-
 from openbb_terminal import feature_flags as obbff
+from openbb_terminal.alternative.realestate import landRegistry_view
+from openbb_terminal.custom_prompt_toolkit import NestedCompleter
 from openbb_terminal.decorators import log_start_end
-from openbb_terminal.menu import session
 from openbb_terminal.helper_funcs import (
     EXPORT_ONLY_RAW_DATA_ALLOWED,
     check_positive,
 )
-from openbb_terminal.rich_config import console, MenuText
+from openbb_terminal.menu import session
 from openbb_terminal.parent_classes import BaseController
-from openbb_terminal.alternative.realestate import landRegistry_view
+from openbb_terminal.rich_config import MenuText, console
 
 logger = logging.getLogger(__name__)
 

openbb_terminal/base_helpers.py

@@ -1,6 +1,6 @@
 # This is for helpers that do NOT import any OpenBB Modules
-from typing import Callable, Any, Literal
 import os
+from typing import Any, Callable, Literal
 
 from rich.console import Console
 

openbb_terminal/common/behavioural_analysis/finbrain_model.py

@@ -4,9 +4,9 @@
 import logging
 
 import pandas as pd
-from openbb_terminal.helper_funcs import request
 
 from openbb_terminal.decorators import log_start_end
+from openbb_terminal.helper_funcs import request
 
 logger = logging.getLogger(__name__)
 

openbb_terminal/common/behavioural_analysis/finbrain_view.py

@@ -3,25 +3,24 @@
 
 import logging
 import os
-from typing import Optional, List
+from typing import List, Optional
 
 import numpy as np
 import pandas as pd
 from matplotlib import pyplot as plt
 
-from openbb_terminal.config_terminal import theme
+from openbb_terminal import rich_config
 from openbb_terminal.common.behavioural_analysis import finbrain_model
 from openbb_terminal.config_plot import PLOT_DPI
+from openbb_terminal.config_terminal import theme
 from openbb_terminal.decorators import log_start_end
 from openbb_terminal.helper_funcs import (
     export_data,
+    is_valid_axes_count,
     plot_autoscale,
     print_rich_table,
-    is_valid_axes_count,
 )
 from openbb_terminal.rich_config import console
-from openbb_terminal import rich_config
-
 
 logger = logging.getLogger(__name__)
 

openbb_terminal/common/behavioural_analysis/finnhub_model.py

@@ -5,9 +5,9 @@
 
 import pandas as pd
 
-from openbb_terminal.helper_funcs import request
 from openbb_terminal import config_terminal as cfg
 from openbb_terminal.decorators import check_api_key, log_start_end
+from openbb_terminal.helper_funcs import request
 from openbb_terminal.rich_config import console
 
 logger = logging.getLogger(__name__)

openbb_terminal/common/behavioural_analysis/finnhub_view.py

@@ -7,10 +7,9 @@
 import pandas as pd
 
 from openbb_terminal.common.behavioural_analysis import finnhub_model
-from openbb_terminal.decorators import log_start_end
+from openbb_terminal.decorators import check_api_key, log_start_end
 from openbb_terminal.helper_funcs import export_data
 from openbb_terminal.rich_config import console
-from openbb_terminal.decorators import check_api_key
 
 logger = logging.getLogger(__name__)
 

openbb_terminal/common/behavioural_analysis/google_view.py

@@ -3,20 +3,20 @@
 
 import logging
 import os
-from typing import Optional, List
-import pandas as pd
+from typing import List, Optional
 
 import matplotlib.pyplot as plt
+import pandas as pd
 
-from openbb_terminal.config_terminal import theme
-from openbb_terminal.config_plot import PLOT_DPI
 from openbb_terminal.common.behavioural_analysis import google_model
+from openbb_terminal.config_plot import PLOT_DPI
+from openbb_terminal.config_terminal import theme
 from openbb_terminal.decorators import log_start_end
 from openbb_terminal.helper_funcs import (
     export_data,
+    is_valid_axes_count,
     plot_autoscale,
     print_rich_table,
-    is_valid_axes_count,
 )
 
 logger = logging.getLogger(__name__)

openbb_terminal/common/behavioural_analysis/reddit_helpers.py

@@ -1,8 +1,8 @@
 """Reddit Helpers"""
 __docformat__ = "numpy"
 
-from typing import List
 import re
+from typing import List
 
 import praw
 

openbb_terminal/common/behavioural_analysis/reddit_model.py

@@ -3,9 +3,9 @@
 # pylint:disable=too-many-lines
 
 import logging
+import warnings
 from datetime import datetime, timedelta
 from typing import List, Tuple
-import warnings
 
 import finviz
 import pandas as pd