Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Papermill installer specific version #3332

Merged
merged 7 commits into from
Nov 9, 2022
Merged

Conversation

simmonsj330
Copy link
Contributor

Description

Addresses #3247 by adding a command to specify the Papermill version to use the git clone after all other dependencies have been installed properly on the environment.
M1 Mac
Screen Shot 2022-11-07 at 3 12 22 PM
Intel Mac
Screen Shot 2022-11-07 at 3 12 40 PM

Windows (This shows that is it failing, but it is failing because of issue #3245 which is addressed by PR #3320.
Screen Shot 2022-11-07 at 3 12 56 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@simmonsj330 simmonsj330 added the build Build-related work label Nov 7, 2022
@simmonsj330 simmonsj330 self-assigned this Nov 7, 2022
@simmonsj330
Copy link
Contributor Author

This also fixes #3318

@jmaslek jmaslek merged commit 0b176ef into main Nov 9, 2022
@jmaslek jmaslek deleted the papermill_installer_version branch November 9, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants