Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing windows build by updating pyproject.toml and commenting out one integration test #3320

Merged
merged 11 commits into from
Nov 10, 2022

Conversation

simmonsj330
Copy link
Contributor

Description

Fixes #3245 by updating to correct versions of charset-normalizer and ipython to pyproject.toml. Additionally made changes to the build workflow file to run all integration tests. There was an issue with test_stocks_options.openbb because it made integration tests take upwards of 5 hours. After commenting this test out, the integration tests now work and pass successfully. A new issue should be made to fix the problem with the test_stocks_options.openbb integration test
Screen Shot 2022-11-04 at 9 41 40 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@simmonsj330 simmonsj330 added bug Fix bug build Build-related work labels Nov 5, 2022
@simmonsj330 simmonsj330 self-assigned this Nov 5, 2022
@jmaslek jmaslek merged commit eead8af into main Nov 10, 2022
@jmaslek jmaslek deleted the windows_auto_fix3 branch November 10, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug build Build-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Windows Build Error Related To Permissions Again
3 participants