Improve ETF menu #3124
Merged
Improve ETF menu #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
? |
What ticker did you use? @jmaslek |
Thats literally from your screenshot |
Ohh looool Yea, because those are "Futures" and "Bills". They don't have any valid stock ticker symbol - which was creating issues. |
jmaslek
reviewed
Oct 27, 2022
Comment on lines
+326
to
+328
| and "Future" not in name | ||
| and "Bill" not in name | ||
| and "Portfolio" not in name |
There was a problem hiding this comment.
There are a lot more edge cases:
This would not handle this one
There was a problem hiding this comment.
Will handle this one. Let me know if you find any that I'm missing
There was a problem hiding this comment.
https://stockanalysis.com/etf/aaau/holdings/
Probably will be the same for any commodity
There was a problem hiding this comment.
https://stockanalysis.com/etf/acio/holdings/
has "Option"
There was a problem hiding this comment.
My latest update covers both of these 👍🏽
There was a problem hiding this comment.
https://stockanalysis.com/etf/adfi/holdings/
Has "Bd" instead of bond. Also has us dollars
HAvent even gotten past "AD" in the alphabet
There was a problem hiding this comment.
https://stockanalysis.com/etf/adme/holdings/
has some fun ones
There was a problem hiding this comment.
What do you mean? These are working as expected
jmaslek
approved these changes
Oct 31, 2022
hjoaquim
pushed a commit
to hjoaquim/OpenBBTerminal
that referenced
this pull request
Nov 1, 2022
* improve etf menu * improve docs * fix tests * should cover more edge cases Co-authored-by: James Maslek <[email protected]>
jmaslek
added a commit
that referenced
this pull request
Nov 1, 2022
* improved integration tests for forex * integration test for dashboards * added more tests to economy * added test for forecast report * added eedbt integration test * added hist tests * added eval command * updatedeconometrics tests * changed order * test removing warning * Revert "test removing warning" This reverts commit 09ca09012156771428b2041b478296dbf2bfc780. * adding todo * Fix top categories and sorting not working (#3025) * Fix categories and sorting not working * Allow sort in ascending order * Documented the new flag * Fixed tests * Fix bad practises Co-authored-by: James Maslek <[email protected]> * [FEAT] StatsForecast AutoETS forecasting model (#2988) * feat: add autoets model * feat: update autoets index * feat: add verbose option * feat: freq preprocessing * feat: improve test size call * feat: add statsforecast dep to conda env full Co-authored-by: James Maslek <[email protected]> Co-authored-by: martinb-bb <[email protected]> * Improve ETF menu (#3124) * improve etf menu * improve docs * fix tests * should cover more edge cases Co-authored-by: James Maslek <[email protected]> * improve export (#3176) * When renaming funcs to remove source at start, the translating keys were missing update (#3177) * fix the en.yml key for some funcs * fix tests Co-authored-by: James Maslek <[email protected]> * Adds guide for SDK/Keys (#3111) * Adds guide for SDK/Keys * Linter * Applied requested changes, and improved the examples. * Removed bullet point Co-authored-by: Jeroen Bouma <[email protected]> * Adds Introduction Guide for the Economy SDK Module (#3142) * Adds Introduction Guide for the Economy SDK Module * Changes title Co-authored-by: Jeroen Bouma <[email protected]> * version check for statforecast (#3227) * Fix 3188 - UX for `Feature Engineering` functions (#3224) * fix depr. warning * console printout enhancment * improvement to sto for UX * average true range UX * signal UX improv. * Fix Some Econometrics Bugs (#3210) * Added suggestions for load * Fixed a command * Fixed panel Co-authored-by: Henrique Joaquim <[email protected]> Co-authored-by: James Maslek <[email protected]> * Fixing 6 crypto bugs (#3228) * fixing 6 crypto bugs * fixing filter stuff Co-authored-by: Colin Delahunty <[email protected]> * Fix SDK plot colors without needing openbb.stocks.candle (#3178) * fix SDK plot colors without needing openbb.stocks.candle * lint * ordering Co-authored-by: James Maslek <[email protected]> Co-authored-by: Colin Delahunty <[email protected]> * Updating crypto integration tests (#3222) * disc, ov, and base * more integration tests and fixing previous commited ones * some more fixes Co-authored-by: Colin Delahunty <[email protected]> * removing commented tests * removing commented tests Co-authored-by: Gerard <[email protected]> Co-authored-by: James Maslek <[email protected]> Co-authored-by: fede <[email protected]> Co-authored-by: martinb-bb <[email protected]> Co-authored-by: DidierRLopes <[email protected]> Co-authored-by: Danglewood <[email protected]> Co-authored-by: Jeroen Bouma <[email protected]> Co-authored-by: Colin Delahunty <[email protected]> Co-authored-by: James Simmons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to load "DBA". Output is much more neat now.