Fix top categories and sorting not working

[Jrryy]

Description

Fixes #3020
Fixed the cgtop command so that a deprecation warning stops appearing, filtering by categories shows integers under the "Market Cap Rank" column, and sorting by certain columns works as expected.

Side note: I have noticed, and confirmed in their website, that CoinGecko ignores the pagination when requesting a category of coins. That's why I've divided the code in two branches depending on whether the user requests a category or not. It's probably worth reporting this to them or asking if this is the expected behaviour.

How has this been tested?

Ran test_crypto_disc.openbb without errors. Also the following screenshots:

Checklist:

• Update our Hugo documentation following these guidelines.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding scripts file.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[jmaslek]

Thanks for this!

I believe this function is getting renamed in #3000 by @northern-64bit. But it doesn't look like this should raise any conflicts.

[OMEGA102781]

I seen 2 on the left, 1was missing. Not sure if code. Is corrupt? situation was Blank, Still trying to get it to reset. It might work. 2386 was my results.

…

On Mon, Oct 24, 2022, 3:21 PM James Maslek ***@***.***> wrote: Thanks for this! I believe this function is getting renamed in #3000 <#3000> by @northern-64bit <https://github.com/northern-64bit>. But it doesn't look like this should raise any conflicts. — Reply to this email directly, view it on GitHub <#3025 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZGP6YJVLL7Z7SZNRRIDDNTWE3OUTANCNFSM6AAAAAARNIAGO4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[jmaslek]

Hey @Jrryy, we merged a PR that renamed some functions. Could you rebase so that we can add this fix :)

[Jrryy]

Yep, going to rebase and fix the failing tests.