Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl fix #2693

Merged
Merged

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Oct 3, 2022

Description

Currently there are 8 integrations failures total which were identified on the M1 & Intel Macs.

test_stocks_ba and test_stocks_scr failures appeared on both.
test_stocks_ca, test_stocks_fa, and test_stocks_sia failures appeared on M1.
test_stocks_disc, test_stocks_dps, and test_stocks_options failures appeared on Intel.

After downloading, running individual integration tests locally on the installer, and manually testing, only test_stocks_ba failed with an SSL error(test_stocks_scr also failed but this can be ignored). This SSL error is the exact same as noted in #2585. The remaining 6 all passed as seen below…

test_stocks_ca
test_stocks_ca_image

test_stocks_fa
test_stocks_fa_image

test_stocks_sia
test_stocks_sia_image

test_stocks_disc
test_stocks_disc_image

test_stocks_dps
test_stocks_dps_image

test_stocks_options
test_stocks_options_image

However, when running integration tests locally on the downloaded installer there was some odd behavior noticed such as failures occurring if you run integration tests in series but not individually, or integration test failures not being able to be replicated, or failures occurring on one run but not another. More investigation should be done to catalog and identify exactly what/when odd behavior occurs. I will reach out to @deeleeramone for this.

However, I do not believe this should hinder the 1.9.0 release and should be a future endeavor.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@simmonsj330 simmonsj330 added bug Fix bug build Build-related work labels Oct 3, 2022
@simmonsj330 simmonsj330 self-assigned this Oct 3, 2022
@colin99d colin99d merged commit da913df into OpenBB-finance:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug build Build-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants