Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there are 8 integrations failures total which were identified on the M1 & Intel Macs.
test_stocks_ba
andtest_stocks_scr
failures appeared on both.test_stocks_ca
,test_stocks_fa
, andtest_stocks_sia
failures appeared on M1.test_stocks_disc
,test_stocks_dps
, andtest_stocks_options
failures appeared on Intel.After downloading, running individual integration tests locally on the installer, and manually testing, only
test_stocks_ba
failed with an SSL error(test_stocks_scr
also failed but this can be ignored). This SSL error is the exact same as noted in #2585. The remaining 6 all passed as seen below…test_stocks_ca
test_stocks_fa
test_stocks_sia
test_stocks_disc
test_stocks_dps
test_stocks_options
However, when running integration tests locally on the downloaded installer there was some odd behavior noticed such as failures occurring if you run integration tests in series but not individually, or integration test failures not being able to be replicated, or failures occurring on one run but not another. More investigation should be done to catalog and identify exactly what/when odd behavior occurs. I will reach out to @deeleeramone for this.
However, I do not believe this should hinder the 1.9.0 release and should be a future endeavor.
Others