Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs for news (SSL, sources) and fred (SSL) #2585

Merged
merged 7 commits into from
Sep 22, 2022
Merged

Fix bugs for news (SSL, sources) and fred (SSL) #2585

merged 7 commits into from
Sep 22, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Sep 21, 2022

Description

Fixes #2182 & also actually fixes the news bug #2524 instead of a patch that warns users. This error was occurring on these two commands because the installer could not find the ssl certs for a machine that is not* the machine that the installer was created on (ec2 instance). In this fix we point the installer to the certifi certs.

Screen Shot 2022-09-21 at 1 55 04 PM

Screen Shot 2022-09-21 at 1 55 16 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the bug Fix bug label Sep 21, 2022
@simmonsj330 simmonsj330 self-assigned this Sep 21, 2022
@piiq piiq changed the title Ssl fred bug Fix bugs for news (SSL, sources) and fred (SSL) Sep 22, 2022
@piiq piiq merged commit 5f5f07c into main Sep 22, 2022
@piiq piiq deleted the ssl_fred_bug branch September 22, 2022 16:32
@simmonsj330 simmonsj330 mentioned this pull request Oct 3, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] OpenBB Terminal do NOT accept API from FRED
3 participants