fix: error #2676 #2683
Merged
fix: error #2676 #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Om were you able to reproduce his issue? |
Not exactly since the dpi it shows in the settings menu is the same as the value you enter but when it goes to actually plot something, it uses the value it loads from the user env value which wasn't being loaded correctly |
|
I see. So I will know if this work based on whether the actual chart dpi changes? |
Yep |
|
|
colin99d
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2676 - although the variable was being written to the user_env_file, it didn't load the user_env_file while setting the variables in the terminal