Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Terminal settings are not being read from the file they are written #2676

Closed
deeleeramone opened this issue Sep 29, 2022 · 3 comments · Fixed by #2683 or #2851
Closed

[Bug] Terminal settings are not being read from the file they are written #2676

deeleeramone opened this issue Sep 29, 2022 · 3 comments · Fixed by #2683 or #2851
Assignees
Labels
bug Fix bug

Comments

@deeleeramone
Copy link
Contributor

I noticed this because the contents of the old .env file in my OpenBBTerminal folder had been updated to be a blank file. Settings for plotautoscaling , dpi , and monitor are being read from the old location .env file. If there are no entries in this file, it goes to "default".

You can test this by removing entries from the .env in the old location, changing a setting in the Terminal settings ( you will see this be updated in ./openbb_terminal/.env) - like dpi 300 - restarting and then looking at the setting menu. You should see that any changes made will be forgotten.

@github-actions github-actions bot added the bug Fix bug label Sep 29, 2022
@colin99d colin99d self-assigned this Sep 30, 2022
@colin99d
Copy link
Contributor

I am not able to reproduce this. I changed DPI to the new value and then reloaded, and settings showed a DPI of 300.

@deeleeramone
Copy link
Contributor Author

This issue has not been resolved. Another example is changing Timezone settings in the installer version.

image

@deeleeramone deeleeramone reopened this Oct 6, 2022
@colin99d
Copy link
Contributor

I think the issue is that settings are not applied instantly. Once I closed and reopened the terminal I got the desired result. Let me dig into how to fix immediately.
Screen Shot 2022-10-14 at 6 43 16 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
2 participants