-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock Scipy to 1.8.1. Fixes OpenBB-finance/OpenBBTerminal#2226 #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @jfarid27, thank you for your contribution. Note that we need to export the poetry export -f requirements.txt -o requirements.txt --without-hashes --dev
poetry export -f requirements.txt -o requirements-full.txt --extras prediction --without-hashes --dev
poetry export -f requirements.txt -o bots/requirements.txt --extras bots --without-hashes --dev |
Added! |
colin99d
approved these changes
Aug 3, 2022
…penBBTerminal into bugfix/rollback-scipy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downgrade Scipy to 1.8.1 to fix openblas update issue. Currently Scipy is at 1.9.0 via deps, and not locked, so new upgrades on M1/M2 architectures fails. This PR rolls back to a stable version.
Issues
Fixes #2226
Dependencies
Scipy 1.9.0 is not listed but a requirement. This PR locks 1.8.1 until a fix is resolved on the main Scipy branch.
Motivation
See #2226.
How has this been tested?
Ran
pytest tests/
. Tests are only failing in trackers and match up with existing failures in other PRs.Currently PR #2225 is failing these tests as well.
Checklist:
Update our Hugo documentation following these guidelines.Update our tests following these guidelines.If a feature was added make sure to add it to the corresponding scripts file.Others
I have commented my code, particularly in hard-to-understand areas.pre-commit install
.pytest tests/...
.