Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Scipy to 1.8.1. Fixes OpenBB-finance/OpenBBTerminal#2226 #2227

Merged
merged 15 commits into from
Aug 9, 2022

Conversation

jfarid27
Copy link
Contributor

@jfarid27 jfarid27 commented Aug 1, 2022

Description

Downgrade Scipy to 1.8.1 to fix openblas update issue. Currently Scipy is at 1.9.0 via deps, and not locked, so new upgrades on M1/M2 architectures fails. This PR rolls back to a stable version.

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

Issues

Fixes #2226

Dependencies

Scipy 1.9.0 is not listed but a requirement. This PR locks 1.8.1 until a fix is resolved on the main Scipy branch.

Motivation

See #2226.

How has this been tested?

Ran pytest tests/. Tests are only failing in trackers and match up with existing failures in other PRs.

======================== short test summary info =========================
FAILED tests/openbb_terminal/stocks/government/test_quiverquant_view.py::test_call_func[display_government_buys-kwargs_dict1]
FAILED tests/openbb_terminal/stocks/government/test_quiverquant_view.py::test_call_func[display_government_sells-kwargs_dict2]
ERROR tests/openbb_terminal/portfolio/test_portfolio_model.py::test_tracking_error

Currently PR #2225 is failing these tests as well.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@Chavithra
Copy link
Contributor

Chavithra commented Aug 2, 2022

Hello @jfarid27,

thank you for your contribution.

Note that we need to export the requirements files too:

poetry export -f requirements.txt  -o requirements.txt --without-hashes --dev
poetry export -f requirements.txt  -o requirements-full.txt --extras prediction --without-hashes --dev
poetry export -f requirements.txt  -o bots/requirements.txt --extras bots --without-hashes --dev

@jfarid27
Copy link
Contributor Author

jfarid27 commented Aug 3, 2022

poetry export -f requirements.txt  -o requirements.txt --without-hashes --dev
poetry export -f requirements.txt  -o requirements-full.txt --extras prediction --without-hashes --dev
poetry export -f requirements.txt  -o bots/requirements.txt --extras bots --without-hashes --dev

Added!

@colin99d colin99d added the bug Fix bug label Aug 3, 2022
@colin99d colin99d self-requested a review August 3, 2022 20:58
@colin99d colin99d merged commit 47b25a9 into OpenBB-finance:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Installing new versions breaks when installing scipy 1.9.0
3 participants