Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecocal improve #2225

Merged
merged 14 commits into from
Aug 4, 2022
Merged

Ecocal improve #2225

merged 14 commits into from
Aug 4, 2022

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Aug 1, 2022

Description

This PR incorporates some feedback given by @deeleeramone.

Major changes are the following:

  • Fix country selection allowing euro zone economic events
  • New default for dates is the current calendar day, instead of limiting to 10 rows
  • New default for ecocal is -c = 'all' & -i = 'high', since the # of events where the importance is high globally is a relatively small number for any single day
  • Fix date formatting to match YYYY-MM-DD
  • Capitalize country names and headers
  • Remove "zone" column when just one country and display country name in header

image

image

image

  • Summary of the change / bug fix.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.

How has this been tested?

ecocal
pytest tests\openbb_terminal\economy\test_investingcom_view.py -k test_display_economic_calendar

Others

  • I have performed a self-review of my own code.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@montezdesousa montezdesousa added the enhancement Enhancement label Aug 1, 2022
@montezdesousa montezdesousa self-assigned this Aug 1, 2022
@montezdesousa montezdesousa marked this pull request as ready for review August 2, 2022 08:18
@minhhoang1023
Copy link
Contributor

looks great! 🚀

@montezdesousa montezdesousa merged commit 1413456 into main Aug 4, 2022
@montezdesousa montezdesousa deleted the ecocal_improve branch August 4, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants