-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow direct orderbook export from degiro paexport to portfolio load command #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2022
Chavithra
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great on my side !
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow users to export their orderbook from degiro #2065 directly into portfolio/holdings default paexport_degiro.csv file. Then the user can immediately load his orderbook through portfolio
load
command choices prompt.To allow loading from path with
load portfolio\holdings\[not_default_file_name].csv
.r I removedchoices=self.DATA_HOLDINGS_FILES,
on the parser argument --file. This fixes part of #2101 by allowing users to load files from arbitrary paths as well.How has this been tested?
Fetch degiro transactions to csv through degiro paexport command
portfolio/bro/degiro/login
paexport -s 2018-01-01
Load previous file through portfolio load command
portfolio/load 20220719_224755_paexport_degiro.csv
Others
pre-commit install
.pytest tests/...
.