Fill missing static data (sector, industry, country and region) on portfolio creation

[montezdesousa]

Description

This PR populates the orderbook loaded in the portfolio menu with sector, industry, country and region if they are not provided by user. This will be useful to allow integration with broker accounts that just provide transaction data (e.g. price, quantity, ticker...) and not much static data. There's a PR already trying to start this integration by exporting a formatted transaction file. See #2065 but it was being blocked by this issue.

Post-review changes:

• Save company data locally after first download, this should speed up load orderbook process by avoiding unnecessary downloads after the first time

• Add progress bar update on loading checkpoints

• Avoid rewriting when company data provided by user

• Summary of the change / bug fix.

• Relevant motivation and context.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
• New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

[JerBouma]

So, when I don't fill anything in the Orderbook, but do keep the columns it doesn't work. Should we remove those altogether? I think we should so there is less manual input required.

If we do, however, it takes longer to load. Could you add in a progression bar or, otherwise, an option to export to .csv so it loads quicker?

[JerBouma]

@montezdesousa How far are you with this PR?

[montezdesousa]

@montezdesousa How far are you with this PR?

I'll be on it this afternoon

[JerBouma]

Is it ready?

[montezdesousa]

Is it ready?

yes, after this one passes I have a WIP (#2091) to change the degiro export orderbook path to portfolio/holdings and the user should be able to paexport their orderbook in degiro and then access the file in the load command of portfolio menu

[DidierRLopes]

@JerBouma is this good to be merged?

[montezdesousa]

@JerBouma is this good to be merged?

@JerBouma as I mentioned to you, my implementation of returns was very poor performance wise, so I added a new commit that I believe fixes this (if ok calculating returns went from 25s to 0.6s for the Public_Equity_Orderbook.xlsx) and the progress bar does not need to be that long

[JerBouma]

Sounds great!