-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pred deps and instructions #1885
Conversation
Currently testing on linux. Two things I noticed with poetry install:
This is not the right subversion of darts. It must include pytorch.
numeric_forecast = predicted_values.quantile_df()["AdjClose_0.5"].tail(n_predict) Which causes this error: Pip must be changing a specific library version that breaks the format. Only when I remove darts and reinstall via conda I shall investigate why. |
Chart pops up for me too. Just printing the table on the console is a problem due to the array format. |
Yup, its because I will speak with the Devs. |
…ons' into update-pred-deps-and-instructions
If I uninstall u8darts[torch] and then reinstall using through the conda command above, I get an error saying:
|
If you exit out of terminal and just open python and try to import darts, does it work? |
Yes, in a Jupyter notebook, import darts works. |
Got it now with no errors on this command, but RNN is now making a different error than before:
|
This is the same issues I was having with Tensorflow on M1. Seems the whole library dependancy chain is spaghetti. That is why I needed to write out full commands (in specific order) for installing on M1. (as we did back a week ago) conda env create -n tester --file build/conda/conda-3-8-env.yaml
conda activate tester
conda install -c apple tensorflow-deps
conda install -c apple tensorflow-deps==2.8.0
python -m pip install tensorflow-metal
conda update -c defaults numpy
pip3 install -r requirements.txt
export GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1
export GRPC_PYTHON_BUILD_SYSTEM_ZLIB=1
pip3 install -r requirements.txt
conda install -c conda-forge tensorflow==2.7.1
conda install -c conda-forge -c pytorch u8darts-torch
python3 -c "import tensorflow as tf; print(tf.reduce_sum(tf.random.normal([1000, 1000])))" Worst case scenario - we delay the addition of the new forecasting Dart models for now until we can package it up properly for the installer and have this resolved offline. |
@deeleeramone let's come back to testing the m1 native build in a few months? it's very raw |
@Chavithra @andrewkenreich anyone of you can test if the environment works on windows? |
Update! It has to do with how pandas manipulates Are we able to update pandas in poetry from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chavithra @andrewkenreich anyone of you can test if the environment works on windows?
Seems to work on windows.
Update! I have found the culprit to the problem with
Error: unsupported format string passed to DataArray.__format__
It has to do with how pandas manipulates
<class 'pandas.core.series.Series'>
. This has been updated in later versions of pandas.Are we able to update pandas in poetry from
1.3.5
-->1.4.2
(aka. latest) ?
I don't see reason against.
We will need to check for side effects though :
- there might be libraries that we use which are not yet compatible with 1.4
- it might break some existing code due to Pandas breaking changes (already append in the past)
Thanks to some findings by @deeleeramone and @martinb-bb, the deps blocker was resolved.
The app launches and doesn’t crash, but it still produces warnings that will disapper as soon as someone closes this issue unit8co/darts#927
As for the instructions and the docs, I've pointed out that we recommend using the rosetta version of conda on macs. The native m1 build is too fragile and was removed from the docs until it will work out of the box.
I've tested that the environment works on an m1 mac with a rosetta conda. I would appreciate a test of the prediction menu on windows and linux.
Test scenario for Windows and Linux:
conda env create -n gst -f build/conda/conda-3-8-env-full.yaml && conda activate gst
poetry install
poetry install -E prediction
python terminal.py stocks/load f/pred/expo