Bug/crypto defi vaults command broken #1822 #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing bout not verified request url
JakubPluta
commented
May 26, 2022
| import pandas as pd | ||
| import requests | ||
|
|
||
| from openbb_terminal.decorators import log_start_end | ||
| from openbb_terminal.helper_funcs import get_user_agent | ||
|
|
||
|
|
||
| urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) |
There was a problem hiding this comment.
To disable Insecure Request Warning I disabled it on coindix_model level, but maybe it should be moved to some more flags/config related place ?
There was a problem hiding this comment.
For now I think this looks good yea!
|
Welcome back @JakubPluta 🚀 For the tests you can do |
Thanks Didier, I have to get used to the current structure of the project, as it changed a "little" from my last PR :) |
|
the tests should pass once this #1885 is merged |
DidierRLopes
approved these changes
Jun 1, 2022
deeleeramone
pushed a commit
to deeleeramone/OpenBBTerminal
that referenced
this pull request
Jun 1, 2022
…ance#1874) * Add separate view for finbrain for crypto curreny sentiment analysis * Move json with symbols to separate directory, little refactoring, update readme * Add screenshot of finbrain for PolkaDot * Fix defi coindix vaults. Risk param is disabled. Disable urllib3 warning bout not verified request url * update tests for coindix - cassetes, csvs, txts * update vaults docs * Update _index.md * run crypto tests with record_mode=rewrite Co-authored-by: didierlopes.eth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coindix changed their API spec. Now endpoint
https://apiv2.coindix.com/searchdoesn't take as query parameterriskkeyword, and also it's not returned in response. Also as get request to mentioned endpoint has flag:response = requests.get(..., verify=False)it screams with urllib3 warnings. That`s why I also disabled this warning in stdout. For now it's in[Bug] Crypto/DeFi/Vaults - Command appears to be broken #1822
Before fix:
After fix.
How has this been tested?
Checklist:
Others
pre-commit install.pytest tests/....