Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs, remove feargeed and improve help messages #1767

Merged
merged 33 commits into from
May 5, 2022
Merged

Fix bugs, remove feargeed and improve help messages #1767

merged 33 commits into from
May 5, 2022

Conversation

piiq
Copy link
Contributor

@piiq piiq commented May 5, 2022

Description

  • fix soup on defi lending and borrowing commands
  • remove broken cnn feargreed command
  • fix and speed up stocks/ba integration tests
  • implement exception handling for whale alert when the api is down
  • added a warning for portfolio optimization functions that run for long time
  • get version number to the welcome message from pyproject.toml

How has this been tested?

After running python terminal.py scripts/*.openbb -t
Summary: Successes: 48 Failures: 4

The failures that I can't reproduce locally are:

test_stocks_dd.openbb: 'NoneType' object has no attribute 'set_index'
test_stocks_options.openbb: Expiration `2022-05-06` cannot be found. Available expiration are: [2022-05-20, 2022-06-17, 2022-07-15, 2022-09-16, 2023-01-20, 2023-03-17, 2023-06-16, 2023-09-15, 2024-01-19]
test_stocks_options_payoff.openbb: Expiration `2022-05-06` cannot be found. Available expiration are: [2022-05-20, 2022-06-17, 2022-07-15, 2022-09-16, 2023-01-20, 2023-03-17, 2023-06-16, 2023-09-15, 2024-01-19]
test_stocks_options_pricing.openbb: Expiration `2022-05-06` cannot be found. Available expiration are: [2022-05-20, 2022-06-17, 2022-07-15, 2022-09-16, 2023-01-20, 2023-03-17, 2023-06-16, 2023-09-15, 2024-01-19]

I say we accept this as a new known issue and leave it out of scope of this PR

Checklist:

  • Update Hugo documentation.
  • Update tests.

@piiq piiq added the bug Fix bug label May 5, 2022
@piiq piiq changed the title Squash bugs Fix bugs spotted while running scripts/*.openbb May 5, 2022
@piiq piiq changed the title Fix bugs spotted while running scripts/*.openbb Fix bugs, remove feargeed and improve help messages May 5, 2022
@piiq piiq merged commit 2ce3fe4 into main May 5, 2022
@piiq piiq deleted the squash-bugs branch May 5, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants