Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs for fetching crypto prices on chain and displaying very small numbers in tables #1762

Merged

Conversation

alexferrari88
Copy link
Contributor

Description

Issue #1741 showed two problems:

  • A message saying "No data found" while actual data is found
  • Very small float numbers are displayed as 0.00
    In this PR I address both problems.

How has this been tested?

$> crypto/onchain
$ crypto/onchain> address -t --address 0x7aE7ACC3B3A9679EAe7e4F7495eAd1429ac7dE7E

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes added the bug Fix bug label May 5, 2022
@piiq
Copy link
Contributor

piiq commented May 5, 2022

@alexferrari88 can you mark to skip the whale alerts key test, please?
image
there is something wrong with their api

@alexferrari88
Copy link
Contributor Author

@alexferrari88 can you mark to skip the whale alerts key test, please? image there is something wrong with their api

sorry for the dumb question but how should I go about it?

@piiq
Copy link
Contributor

piiq commented May 5, 2022

@alexferrari88 I've fixed the whale alerts issue in #1767
Once it's merged you can sync with main and tests will pass here

@piiq
Copy link
Contributor

piiq commented May 5, 2022

Resolves #1741

@piiq piiq merged commit 5791c09 into OpenBB-finance:main May 5, 2022
@alexferrari88 alexferrari88 deleted the feature/crypto_onchain_small_digits branch May 5, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants