Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wo read only init #9395

Closed
wants to merge 13 commits into from

Conversation

gbmarc1
Copy link
Contributor

@gbmarc1 gbmarc1 commented May 4, 2021

Constructor for readOnly parameters

@spacether

Related to #9296

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

wing328 and others added 11 commits April 28, 2021 22:36
* nim petstore to use 3.0 spec

* ktorm to use 3.0 spec

* update c petstore to use 3.0 spec

* Revert "update c petstore to use 3.0 spec"

This reverts commit a8ff051.
…ls#9321)

* generation type on  template dir path

* remove gen_type from template and resources
…PITools#8624)

* [scala][akka] Update dependencies for scala 2.13

* Update pom.mustache to support multiple scala's version

* Update pom.xml

* Scala cross build 2.12 and 2.13

* Update version. Migrate to sbt

* Remove space

* Add pom.xml back
…penAPITools#9271)

* Avoid DeprecationWarning in inspect.getargspec on Python 3

* Regenerate samples
* [TypeScript] Fix misplaced parentheses

* [TypeScript] Run PR relevant scripts

* [TypeScript] ensure up to date

* Revert "[TypeScript] ensure up to date"

This reverts commit 320ec45

* Revert "[TypeScript] Run PR relevant scripts"

This reverts commit 23cda75

Co-authored-by: Stefan Wendt <[email protected]>
…ly_init

# Conflicts:
#	modules/openapi-generator/src/main/resources/python/model_utils.mustache
#	modules/openapi-generator/src/test/resources/3_0/python/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml
#	samples/openapi3/client/petstore/python/petstore_api/model_utils.py
@gbmarc1 gbmarc1 requested a review from jimschubert as a code owner May 4, 2021 12:39
@spacether
Copy link
Contributor

spacether commented May 4, 2021

It looks like you built this on the 5.2.x branch so it needs to target that branch forthe merge. Can you rebase your pr on the 5.2.x branch?

@spacether spacether changed the base branch from master to 5.2.x May 4, 2021 14:34
@@ -1,7 +1,7 @@
generatorName: ktorm-schema
outputDir: samples/schema/petstore/ktorm
inputSpec: modules/openapi-generator/src/test/resources/2_0/petstore.yaml
inputSpec: modules/openapi-generator/src/test/resources/3_0/petstore.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated, why is it being changed?

@gbmarc1 gbmarc1 closed this May 5, 2021
@gbmarc1 gbmarc1 deleted the feature/wo_readOnly_init branch May 5, 2021 15:33
@spacether
Copy link
Contributor

This was replaced by #9409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants