[BUG] new.sh fix generator type

[AndersSpringborg]

This is a small fix, for generating a new template. It helps getting started.
I found the issue today, as I was making a new generator.

I've made a Issue, describing the problem #9320

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master, 5.1.x, 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[wing328]

@AndersSpringborg thanks for the PR but I think we usually use the generator name directly as the template folder name (e.g. lua, perl) without adding the generator type (e.g. client, server)

[AndersSpringborg]

Oh yeah, i see what you mean!

If you follow the instruction on how to make a new client generator, for a new platform, it throws an exception, that it cannot find that template. I'll look into what course the problem tomorrow 😊

Exception in thread "main" java.lang.IllegalArgumentException: Template directory modules/openapi-generator/src/main/resources/test does not exist.
	at org.openapitools.codegen.config.WorkflowSettings$Builder.withTemplateDir(WorkflowSettings.java:503)
	at org.openapitools.codegen.config.WorkflowSettings.newBuilder(WorkflowSettings.java:124)
	at org.openapitools.codegen.config.DynamicSettings.getWorkflowSettings(DynamicSettings.java:84)
	at org.openapitools.codegen.config.CodegenConfigurator.fromFile(CodegenConfigurator.java:91)
	at org.openapitools.codegen.cmd.Generate.execute(Generate.java:272)
	at org.openapitools.codegen.cmd.OpenApiGeneratorCommand.run(OpenApiGeneratorCommand.java:32)
	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:66)
	```

[AndersSpringborg]

In the the script, the template folder is created with ${gen_name_camel}-${gen_type}

openapi-generator/new.sh

Lines 193 to 200 in 0f5e7d1

	# Step 3: Create resource files
	mkdir -p "${root}/modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}"
	echo "Creating modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/README.mustache" && \
	touch "${root}/modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/README.mustache"
	echo "Creating modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/model.mustache" && \
	touch "${root}/modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/model.mustache"
	echo "Creating modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/api.mustache" && \
	touch "${root}/modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/api.mustache"

So the template dir in the config, should have the same path

openapi-generator/new.sh

Line 208 in 0f5e7d1

templateDir: modules/openapi-generator/src/main/resources/${gen_name_camel}

[wing328]

Good point. What about updating these lines instead following the convention that I mentioned?

# Step 3: Create resource files 
 mkdir -p "${root}/modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}" 
 echo "Creating modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/README.mustache" && \ 
     touch "${root}/modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/README.mustache" 
 echo "Creating modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/model.mustache" && \ 
     touch "${root}/modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/model.mustache" 
 echo "Creating modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/api.mustache" && \ 
     touch "${root}/modules/openapi-generator/src/main/resources/${gen_name_camel}-${gen_type}/api.mustache" 

cc @jimschubert

[AndersSpringborg]

Let me know if that's how you want the script to work! I'll go through it, and make sure it works with this naming convention

[wing328]

Please update based on #9321 (comment). Thank you.

[wing328]

Tested and looks good

./new.sh -n julia -c
Creating modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JuliaClientCodegen.java
Creating modules/openapi-generator/src/main/resources/julia/README.mustache
Creating modules/openapi-generator/src/main/resources/julia/model.mustache
Creating modules/openapi-generator/src/main/resources/julia/api.mustache
Creating bin/configs/julia-petstore-new.yaml
Finished.