[ci] Execute maven and verify with no-snapshot-updates #6415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
May 27, 2020
* master: [kotlin][client] add support for coroutines with OkHttp (OpenAPITools#6362) update package-json.lock (OpenAPITools#6430) fix hardcoded match type (OpenAPITools#6431) java jersey2 enhance anyOf (OpenAPITools#6420) [Java][jersey2] minor improvement to jersey2 tests (OpenAPITools#6418) ps minor style change (OpenAPITools#6424) [JS] mark ES5 as deprecated (OpenAPITools#6408) [ci] Execute maven and verify with no-snapshot-updates (OpenAPITools#6415) add new file in ts axios samples Migrate all scala generators to use OAS3 (OpenAPITools#6407) migrate ruby samples to oas3 (OpenAPITools#6414) [PS] check if JSON properties is defined (OpenAPITools#6419) Add C++ UE4 client generator (OpenAPITools#6399) Add a link to the article in dev.to (OpenAPITools#6421) typescript-axios anytype is not defined (OpenAPITools#6335) [Java][jersey2] Make (de)serialization work for oneOf models, add convenience and comparison methods (OpenAPITools#6323) Migrate OCaml petstore to use OAS v3 spec (OpenAPITools#6348) [Python-experimental] Fix type error if oneof/anyof child schema is null type (OpenAPITools#6387) [Python-server] Fix blueplanet 'file not found' error (OpenAPITools#6411) [nodejs] Fix deprecation notice when running sample nodejs script (OpenAPITools#6412)
jimschubert
added a commit
that referenced
this pull request
May 27, 2020
* master: [kotlin][client] add support for coroutines with OkHttp (#6362) update package-json.lock (#6430) fix hardcoded match type (#6431) java jersey2 enhance anyOf (#6420) [Java][jersey2] minor improvement to jersey2 tests (#6418) ps minor style change (#6424) [JS] mark ES5 as deprecated (#6408) [ci] Execute maven and verify with no-snapshot-updates (#6415) add new file in ts axios samples Migrate all scala generators to use OAS3 (#6407) migrate ruby samples to oas3 (#6414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set Maven's
--no-snapshot-updatesoption in CI. Although certain providers may configure snapshot updates, it's unclear across our providers what would occur if we runmvn installin one command, followed bymvn verifyin another during which time a SNAPSHOT release was published on master. Declaring this option provides some certainty across all providers where we follow this approach. Because we also run with--quiet, we reduce our visibility into whether CI is downloading the SNAPSHOT or using the locally cached version.Gradle doesn't require such an option because it caches snapshot dependencies for 24 hours by default and requires either manual updates or reconfiguration to change that behavior (see https://docs.gradle.org/current/userguide/dynamic_versions.html).
cc @OpenAPITools/generator-core-team
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.