Add C++ UE4 client generator #6399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wing328 Hello, I have reviewed this, it looks fine for me. |
|
@wing328 As discussed, escaping dots in symbol names could probably be moved to the abstract CPP codegen level, as well as post processing model enums |
|
@Kahncode Done. I've switched it to |
|
This is great, @wing328 out of curiosity why not do this in sanitizeName? This is where other wrong symbols were escaped. Are enums still post-processed in this version? |
|
Those dots are actually useful for camelize (and other string utils such as underscore), e.g. this.is.my.name => Yes, enums are still post-processed properly in this PR. |
|
As discussed, we'll file separate PRs to further improve this generator. |
jimschubert
added a commit
that referenced
this pull request
May 25, 2020
* master: (71 commits) [PS] check if JSON properties is defined (#6419) Add C++ UE4 client generator (#6399) Add a link to the article in dev.to (#6421) typescript-axios anytype is not defined (#6335) [Java][jersey2] Make (de)serialization work for oneOf models, add convenience and comparison methods (#6323) Migrate OCaml petstore to use OAS v3 spec (#6348) [Python-experimental] Fix type error if oneof/anyof child schema is null type (#6387) [Python-server] Fix blueplanet 'file not found' error (#6411) [nodejs] Fix deprecation notice when running sample nodejs script (#6412) [java-jersey2] Conditionally include http signature mustache template (#6413) [bug] Fix path provider bug on CI (#6409) decomission nodejs server generator (#6406) [Java] Generate valid code if no Authentication implementations present (#5788) update java jersey2 samples [Java] Fix mustache tag in pom template for HTTP signature (#6404) [Python-experimental] Rename from_server variable to json_variable_naming (#6390) Add a link to medium blog post (#6403) Clean up debug in test (#6398) readding bin/swift5-petstore-readonlyProperties.json remove ./bin/swift5-petstore-readonlyProperties.json ...
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
May 27, 2020
* master: [kotlin][client] add support for coroutines with OkHttp (OpenAPITools#6362) update package-json.lock (OpenAPITools#6430) fix hardcoded match type (OpenAPITools#6431) java jersey2 enhance anyOf (OpenAPITools#6420) [Java][jersey2] minor improvement to jersey2 tests (OpenAPITools#6418) ps minor style change (OpenAPITools#6424) [JS] mark ES5 as deprecated (OpenAPITools#6408) [ci] Execute maven and verify with no-snapshot-updates (OpenAPITools#6415) add new file in ts axios samples Migrate all scala generators to use OAS3 (OpenAPITools#6407) migrate ruby samples to oas3 (OpenAPITools#6414) [PS] check if JSON properties is defined (OpenAPITools#6419) Add C++ UE4 client generator (OpenAPITools#6399) Add a link to the article in dev.to (OpenAPITools#6421) typescript-axios anytype is not defined (OpenAPITools#6335) [Java][jersey2] Make (de)serialization work for oneOf models, add convenience and comparison methods (OpenAPITools#6323) Migrate OCaml petstore to use OAS v3 spec (OpenAPITools#6348) [Python-experimental] Fix type error if oneof/anyof child schema is null type (OpenAPITools#6387) [Python-server] Fix blueplanet 'file not found' error (OpenAPITools#6411) [nodejs] Fix deprecation notice when running sample nodejs script (OpenAPITools#6412)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @Kahncode
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)