typescript-fetch: add option for TypeScript 3.6+ compatible generation #3801
Conversation
|
Maybe we could introduce an option to chose typescript3+? This way it would not be a breaking change |
|
@macjohnny : Any guidance on how I should add options to the client generator? |
someone1
force-pushed
the
fix-3798
branch
3 times, most recently
from
ce27aee to
e776e78
Compare
|
@macjohnny I think it's ready for review - hopefully I did this all correctly! |
|
@someone1 thanks for your PR! Can you fix this? |
| @@ -0,0 +1,32 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Please add a windows-version in /bin/windows, too
There was a problem hiding this comment.
Maybe this script still needs to be made executable, i.e.
chmod u+x bin/typescript-fetch-petetore-typescript-three-plus.sh
There was a problem hiding this comment.
The command was git update-index --chmod=+x bin/typescript-fetch-petstore-typescript-three-plus.sh for me (using WSL/Windows so maybe that's what screwed this up)
|
@macjohnny - ready for review again, added the windows batch file |
someone1
changed the title
|
please remove the newline at the end of |
|
@macjohnny - done |
|
@someone1 thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
The 3.6 release of typescript has some breaking changes that break the generated code. This PR updates the typescript-fetch generator to TypeScript 3.6 and replaces GlobalFetch with WindowOrWorkerGlobalScope.
I'd be happy to switch down to TypeScript 3.0 (I think this is the minimum version required for this change).
fixes #3798
cc:
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)