Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [typescript-fetch] TypeScript 3.6 breaks generated code #3798

Closed
6 tasks
someone1 opened this issue Aug 29, 2019 · 5 comments · Fixed by #3801
Closed
6 tasks

[BUG] [typescript-fetch] TypeScript 3.6 breaks generated code #3798

someone1 opened this issue Aug 29, 2019 · 5 comments · Fixed by #3801

Comments

@someone1
Copy link
Contributor

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

The 3.6 release of typescript has some breaking changes that break the generated code. Now the generated code ships with TypeScript 2.4, but some (or at least I) like to update this to the latest for any free optimizations that may come with it.

openapi-generator version

4.1.0

Suggest a fix

GlobalFetch was removed, so use it's namespaced version under WindowOrWorkerGlobalScope

@auto-labeler
Copy link

auto-labeler bot commented Aug 29, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@someone1
Copy link
Contributor Author

cc @macjohnny

@macjohnny
Copy link
Member

@someone1 are you willing to fix this?

@someone1
Copy link
Contributor Author

Working on it now - should I bump the typescript version to 3.6 the packages.json ships with?

@someone1
Copy link
Contributor Author

FYI - I think 3.0 would be the minimum version required for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants