Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to run ./bin/openapi3/**/*.sh before submitting new PR. #2071

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

autopp
Copy link
Contributor

@autopp autopp commented Feb 6, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix #2070.
This PR updates PR template to ensure that ./bin/openapi3/**/.sh is executed before sumitting new PR.

…3/security/{LANG}-petstore.sh` before submitting new PR.
@autopp autopp changed the title Request to run ./bin/openapi3/**/.sh before submitting new PR. Request to run ./bin/openapi3/**/*.sh before submitting new PR. Feb 7, 2019
@wing328
Copy link
Member

wing328 commented Feb 7, 2019

The update looks reasonable to me.

@wing328 wing328 merged commit f1a5644 into OpenAPITools:master Feb 7, 2019
@wing328 wing328 added this to the 4.0.0 milestone Feb 7, 2019
@autopp autopp deleted the fix-2070 branch February 7, 2019 04:14
@autopp
Copy link
Contributor Author

autopp commented Feb 7, 2019

@wing328 Thanks for merge!

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…3/security/{LANG}-petstore.sh` before submitting new PR. (OpenAPITools#2071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants