Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The execution of bin/openapi3/{LANG}-petshop.sh is not included in PR checklist #2070

Closed
7 tasks
autopp opened this issue Feb 6, 2019 · 0 comments
Closed
7 tasks

Comments

@autopp
Copy link
Contributor

autopp commented Feb 6, 2019

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

Current PR template requires to only run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh.

  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.

However, in fact, ./bin/openapi3/{LANG}-petstore.sh also needs to be executed. If you push it without executing it, the CI job will fail.
For example, the job failed when I submitted #2068.
https://circleci.com/gh/OpenAPITools/openapi-generator/4649#tests/containers/2

openapi-generator version
$ git log --oneline -n 1
dd3e6c6a3b (HEAD -> master, origin/master, origin/HEAD) Use actual value of generateSourceCodeOnly in python generator. (#2015)
OpenAPI declaration file content or url

N/A

Command line used for generation

N/A

Steps to reproduce

N/A

Related issues/PRs

N/A

Suggest a fix

Would you like to add ./bin/openapi3/{LANG}-petstore.sh to the checklist in .github/PULL_REQUEST_TEMPLATE.md as well?

@autopp autopp changed the title [BUG] The execution of bin/openapi3/{LANG}-petshop.sh is not included in PR checklist The execution of bin/openapi3/{LANG}-petshop.sh is not included in PR checklist Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant