Improve handling of pekko versions in scala-akka-http-server generator #20277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a fix for Issue 20225 - Improve handling of pekko versions
#20275
This change adds a new parameter for the
scala-akka-http-server
generator. The parameter is calledpekkoHttpVersion
and lets a user control the version of thepekko-http
package in the same way you do forakka-http
versions.The change also increases the version of
pekko-stream
to1.0.3
.To validate the work in this PR, run the
scala-akka-http-generator
:usePekkoHttp
flag should have the same bahavior as beforeusePekkoHttp=true
should add pekko packages instead of akka packages just as before, but thepekko-stream
package should now have version1.0.3
. The version ofpekko-http
should still be1.0.0
as long as thepekkoHttpVersion
parameter is not provided.usePekkoHttp=true
andpekkoHttpVersion=someVersion
should result in pekko packages being used instead of akka and the version ofpekko-http
should be whatever was provided in thepekkoHttpVersion
paramater.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@clasnake , @shijinkui , @ramzimaalej , @chameleon82 , @Bouillie , @Fish86