Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of pekko versions in scala-akka-http-server generator #20277

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

bjolletz
Copy link
Contributor

@bjolletz bjolletz commented Dec 9, 2024

This change is a fix for Issue 20225 - Improve handling of pekko versions
#20275

This change adds a new parameter for the scala-akka-http-server generator. The parameter is called pekkoHttpVersion and lets a user control the version of the pekko-http package in the same way you do for akka-http versions.

The change also increases the version of pekko-stream to 1.0.3.

To validate the work in this PR, run the scala-akka-http-generator:

  • Not using the usePekkoHttp flag should have the same bahavior as before
  • usePekkoHttp=true should add pekko packages instead of akka packages just as before, but the pekko-stream package should now have version 1.0.3. The version of pekko-http should still be 1.0.0 as long as the pekkoHttpVersion parameter is not provided.
  • usePekkoHttp=true and pekkoHttpVersion=someVersion should result in pekko packages being used instead of akka and the version of pekko-http should be whatever was provided in the pekkoHttpVersion paramater.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@clasnake , @shijinkui , @ramzimaalej , @chameleon82 , @Bouillie , @Fish86

@ramzimaalej
Copy link
Contributor

LGTM

@wing328
Copy link
Member

wing328 commented Dec 10, 2024

https://github.com/OpenAPITools/openapi-generator/actions/runs/12252917548/job/34180935976?pr=20277

please update the samples when you've time

@wing328 wing328 merged commit b218e23 into OpenAPITools:master Dec 11, 2024
28 checks passed
@wing328 wing328 added this to the 7.11.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants